From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from ananke.telenet-ops.be ([195.130.137.78]:41609 "EHLO ananke.telenet-ops.be" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751932AbXJMSiq (ORCPT ); Sat, 13 Oct 2007 14:38:46 -0400 Date: Sat, 13 Oct 2007 20:38:43 +0200 (CEST) From: Geert Uytterhoeven To: Larry Finger cc: Linus Torvalds , Andrew Morton , Michael Buesch , linux-m68k@vger.kernel.org, linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org Subject: Re: [patch 7/8] b43 wireless needs In-Reply-To: <4710E2C6.5090302@lwfinger.net> Message-ID: (sfid-20071013_193852_317229_435FD936) References: <20071013123123.085686856@mail.of.borg> <20071013123414.160200918@mail.of.borg> <4710E2C6.5090302@lwfinger.net> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-wireless-owner@vger.kernel.org List-ID: On Sat, 13 Oct 2007, Larry Finger wrote: > Geert Uytterhoeven wrote: > > linux/drivers/net/wireless/b43/pio.h: In function 'b43_pio_write': > > linux/drivers/net/wireless/b43/pio.h:89: error: implicit declaration of function 'mmiowb' > > > > linux/drivers/net/wireless/b43/phy.c: In function 'b43_phy_write': > > linux/drivers/net/wireless/b43/phy.c:301: error: implicit declaration of function 'mmiowb' > > > > linuxdrivers/net/wireless/b43/sysfs.c: In function 'b43_attr_interfmode_store': > > linuxdrivers/net/wireless/b43/sysfs.c:147: error: implicit declaration of function 'mmiowb' > > From the distribution list for this E-mail, I presume this error occurred for m68k. Is this correct? That's correct. > If so, I will probably need to prepare a similar patch for b43legacy. I had no problems compiling b43legacy on m68k, though. Probably was included through some other include file. Of course it's safer to always #include when using I/O. During linking, I did get a bunch of `undefined reference to `dma_*'' errors, with both b43 and b43legacy (and a few other drivers). Probably they need to depend on HAS_DMA. I'll post separate patches for those after I've sorted them out. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds