From: "Robert P. J. Day" <rpjday@crashcourse.ca>
To: Zhu Yi <yi.zhu@intel.com>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH] WIRELESS: Use more obvious "is_power_of_2" macro.
Date: Thu, 8 Nov 2007 06:38:18 -0500 (EST) [thread overview]
Message-ID: <Pine.LNX.4.64.0711080638030.18934@localhost.localdomain> (raw)
In-Reply-To: <1194512218.31257.308.camel@debian.sh.intel.com>
On Thu, 8 Nov 2007, Zhu Yi wrote:
>
> On Tue, 2007-11-06 at 09:47 -0500, Robert P. J. Day wrote:
> > Signed-off-by: Robert P. J. Day <rpjday@crashcourse.ca>
> >
>
> NACK. is_power_of_2() cannot do compile time check for
> TFD_QUEUE_SIZE_MAX. Furthermore, the runtime check for
> TFD_QUEUE_SIZE_MAX is already done by iwl_queue_init().
>
> Thanks,
> -yi
right, sorry.
rday
--
========================================================================
Robert P. J. Day
Linux Consulting, Training and Annoying Kernel Pedantry
Waterloo, Ontario, CANADA
http://crashcourse.ca
========================================================================
prev parent reply other threads:[~2007-11-08 11:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-06 14:47 [PATCH] WIRELESS: Use more obvious "is_power_of_2" macro Robert P. J. Day
2007-11-08 8:56 ` Zhu Yi
2007-11-08 11:38 ` Robert P. J. Day [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0711080638030.18934@localhost.localdomain \
--to=rpjday@crashcourse.ca \
--cc=linux-wireless@vger.kernel.org \
--cc=yi.zhu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox