From: Julia Lawall <julia@diku.dk>
To: Pierre Louis Aublin <pierre-louis.aublin@inria.fr>
Cc: Bing Zhao <bzhao@marvell.com>,
kernel-janitors@vger.kernel.org,
"John W. Linville" <linville@tuxdriver.com>,
linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/4] drivers/net/wireless/mwifiex/scan.c: test the just-initialized value
Date: Mon, 22 Aug 2011 16:12:16 +0200 (CEST) [thread overview]
Message-ID: <Pine.LNX.4.64.1108221612090.10948@ask.diku.dk> (raw)
In-Reply-To: <4E52638C.8080407@inria.fr>
On Mon, 22 Aug 2011, Pierre Louis Aublin wrote:
> Hello all
>
> On 08/22/2011 04:00 PM, Julia Lawall wrote:
> > - if (!bss_desc) {
> > + if (!beacon_ie) {
> > dev_err(priv->adapter->dev, " failed to alloc bss_desc\n");
> Shouldn't we also modify the error message, from "failed to alloc bss_desc" to
> "failed to alloc beacon_ie" ?
Sure :)
julia
next prev parent reply other threads:[~2011-08-22 14:12 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-22 14:00 [PATCH 4/4] drivers/net/wireless/mwifiex/scan.c: test the just-initialized value Julia Lawall
2011-08-22 14:11 ` Pierre Louis Aublin
2011-08-22 14:12 ` Julia Lawall [this message]
2011-08-22 14:16 ` Julia Lawall
2011-08-22 19:02 ` Bing Zhao
2011-08-22 19:09 ` walter harms
2011-08-22 19:29 ` Bing Zhao
2011-08-22 15:19 ` Larry Finger
2011-08-22 15:28 ` Julia Lawall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.1108221612090.10948@ask.diku.dk \
--to=julia@diku.dk \
--cc=bzhao@marvell.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=netdev@vger.kernel.org \
--cc=pierre-louis.aublin@inria.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox