Re: [PATCH 1/2] mmc: sdio: Move SDIO IDs from rtl8723bs, driver to common include file

Arend Van Spriel
2020-11-26T06:57:42Z

[-- Attachment #1: Type: text/plain, Size: 513 bytes --]

On November 25, 2020 8:13:07 PM Greg Kroah-Hartman
<gregkh@linuxfoundation.org> wrote:

> On Wed, Nov 25, 2020 at 01:33:00PM -0500, Brian O'Keefe wrote:
>> Macro names were derived from the Windows driver, as that was the best
>> available source.
>
> Why move these? What does this help with?

Hi Greg,

Most if not all SDIO-based (wifi) drivers in mainline have their venid and
devid definitions in that header file. So seems like a good idea to me, but
maybe not so for a staging driver?

Regards,
Arend

[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4176 bytes --]