linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] wifi: ath12k: use kfree_skb() instead of kfree()
@ 2023-02-16 12:16 Dan Carpenter
  2023-02-20  8:35 ` Kalle Valo
  0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2023-02-16 12:16 UTC (permalink / raw)
  To: Kalle Valo
  Cc: P Praneesh, Bhagavathi Perumal S, Wen Gong,
	Balamurugan Selvarajan, Baochen Qiang, ath12k, linux-wireless,
	kernel-janitors

Sk_buffs are supposed to be freed with kfree_skb().

Fixes: d889913205cf ("wifi: ath12k: driver for Qualcomm Wi-Fi 7 devices")
Signed-off-by: Dan Carpenter <error27@gmail.com>
---
 drivers/net/wireless/ath/ath12k/dp_tx.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/wireless/ath/ath12k/dp_tx.c b/drivers/net/wireless/ath/ath12k/dp_tx.c
index 95294f35155c..fd8d850f9818 100644
--- a/drivers/net/wireless/ath/ath12k/dp_tx.c
+++ b/drivers/net/wireless/ath/ath12k/dp_tx.c
@@ -270,7 +270,7 @@ int ath12k_dp_tx(struct ath12k *ar, struct ath12k_vif *arvif,
 					  skb_ext_desc->len, DMA_TO_DEVICE);
 		ret = dma_mapping_error(ab->dev, ti.paddr);
 		if (ret) {
-			kfree(skb_ext_desc);
+			kfree_skb(skb_ext_desc);
 			goto fail_unmap_dma;
 		}
 
-- 
2.39.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] wifi: ath12k: use kfree_skb() instead of kfree()
  2023-02-16 12:16 [PATCH] wifi: ath12k: use kfree_skb() instead of kfree() Dan Carpenter
@ 2023-02-20  8:35 ` Kalle Valo
  0 siblings, 0 replies; 2+ messages in thread
From: Kalle Valo @ 2023-02-20  8:35 UTC (permalink / raw)
  To: Dan Carpenter
  Cc: Kalle Valo, P Praneesh, Bhagavathi Perumal S, Wen Gong,
	Balamurugan Selvarajan, Baochen Qiang, ath12k, linux-wireless,
	kernel-janitors

Dan Carpenter <error27@gmail.com> wrote:

> Sk_buffs are supposed to be freed with kfree_skb().
> 
> Fixes: d889913205cf ("wifi: ath12k: driver for Qualcomm Wi-Fi 7 devices")
> Signed-off-by: Dan Carpenter <error27@gmail.com>
> Signed-off-by: Kalle Valo <quic_kvalo@quicinc.com>

Patch applied to ath-next branch of ath.git, thanks.

8c464d16809f wifi: ath12k: use kfree_skb() instead of kfree()

-- 
https://patchwork.kernel.org/project/linux-wireless/patch/Y+4ejiYakhEvEw7c@kili/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2023-02-20  8:36 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-02-16 12:16 [PATCH] wifi: ath12k: use kfree_skb() instead of kfree() Dan Carpenter
2023-02-20  8:35 ` Kalle Valo

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).