From: Greg KH <gregkh@linuxfoundation.org>
To: Jaewan Kim <jaewan@google.com>
Cc: johannes@sipsolutions.net, linux-wireless@vger.kernel.org,
netdev@vger.kernel.org, kernel-team@android.com,
adelva@google.com
Subject: Re: [PATCH v7 1/4] mac80211_hwsim: add PMSR capability support
Date: Tue, 7 Feb 2023 10:12:00 +0100 [thread overview]
Message-ID: <Y+IV4OYhrhyhhrBz@kroah.com> (raw)
In-Reply-To: <20230207085400.2232544-2-jaewan@google.com>
On Tue, Feb 07, 2023 at 08:53:57AM +0000, Jaewan Kim wrote:
> @@ -5053,6 +5097,74 @@ static bool hwsim_known_ciphers(const u32 *ciphers, int n_ciphers)
> return true;
> }
>
> +static int parse_ftm_capa(const struct nlattr *ftm_capa, struct cfg80211_pmsr_capabilities *out,
> + struct genl_info *info)
> +{
> + struct nlattr *tb[NL80211_PMSR_FTM_CAPA_ATTR_MAX + 1];
> + int ret = nla_parse_nested(tb, NL80211_PMSR_FTM_CAPA_ATTR_MAX,
> + ftm_capa, hwsim_ftm_capa_policy, NULL);
> + if (ret) {
> + NL_SET_ERR_MSG_ATTR(info->extack, ftm_capa, "malformed FTM capability");
> + return -EINVAL;
> + }
Another minor nit, you should have a blank line after the variable list
and before any real logic, right?
You do that in other places in this patch too.
thanks,
greg k-h
next prev parent reply other threads:[~2023-02-07 9:12 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-07 8:53 [PATCH v7 0/4] mac80211_hwsim: Add PMSR support Jaewan Kim
2023-02-07 8:53 ` [PATCH v7 1/4] mac80211_hwsim: add PMSR capability support Jaewan Kim
2023-02-07 9:08 ` Greg KH
2023-02-07 9:12 ` Greg KH [this message]
2023-02-15 18:01 ` Johannes Berg
2023-02-17 5:11 ` Jaewan Kim
2023-02-17 7:43 ` Greg KH
2023-02-17 9:13 ` Johannes Berg
2023-02-17 9:31 ` Greg KH
2023-02-17 9:34 ` Johannes Berg
2023-02-17 9:41 ` Greg KH
2023-02-17 9:19 ` Johannes Berg
2023-02-07 8:53 ` [PATCH v7 2/4] mac80211_hwsim: add PMSR request support via virtio Jaewan Kim
2023-02-15 18:07 ` Johannes Berg
2023-02-23 15:38 ` Jaewan Kim
2023-02-28 15:06 ` Johannes Berg
2023-02-07 8:53 ` [PATCH v7 3/4] mac80211_hwsim: add PMSR abort " Jaewan Kim
2023-02-07 8:54 ` [PATCH v7 4/4] mac80211_hwsim: add PMSR report " Jaewan Kim
2023-02-15 18:13 ` Johannes Berg
2023-02-07 9:06 ` [PATCH v7 0/4] mac80211_hwsim: Add PMSR support Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y+IV4OYhrhyhhrBz@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=adelva@google.com \
--cc=jaewan@google.com \
--cc=johannes@sipsolutions.net \
--cc=kernel-team@android.com \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).