Re: [PATCH v2] wifi: mt76: fix bandwidth 80MHz link fail in 6GHz band

[Lorenzo Bianconi <lorenzo@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 2079 bytes --]

> Hi Lorenzo,
> 
> On Tue, 2022-10-25 at 10:33 +0200, Lorenzo Bianconi wrote:
> > > From: Ming Yen Hsieh <mingyen.hsieh@mediatek.com>
> > > 
> > > Due to information missing, the firmware may be fail on bandwidth
> > > related settings in mt7921/mt7922. Add new cmd STA_REC_HE_V2 to
> > > apply
> > > additional capabilities in 6GHz band.
> > > 
> > > Tested-by: Ben Greear <greearb@candelatech.com>
> > > Co-developed-by: Deren Wu <deren.wu@mediatek.com>
> > > Signed-off-by: Deren Wu <deren.wu@mediatek.com>
> > > Signed-off-by: Ming Yen Hsieh <mingyen.hsieh@mediatek.com>
> > > ---
> > > v2: Fix le16/cpu type problem, reported by kernel test robot <
> > > lkp@intel.com>
> > > ---
> > >  .../wireless/mediatek/mt76/mt76_connac_mcu.c  | 34
> > > +++++++++++++++++++
> > >  .../wireless/mediatek/mt76/mt76_connac_mcu.h  | 11 ++++++
> > >  2 files changed, 45 insertions(+)
> > > 
> > > diff --git a/drivers/net/wireless/mediatek/mt76/mt76_connac_mcu.c
> > > b/drivers/net/wireless/mediatek/mt76/mt76_connac_mcu.c
> > > index 011fc9729b38..9bba18d24c71 100644
> > > --- a/drivers/net/wireless/mediatek/mt76/mt76_connac_mcu.c
> > > +++ b/drivers/net/wireless/mediatek/mt76/mt76_connac_mcu.c
> > > @@ -744,6 +744,39 @@ mt76_connac_mcu_sta_he_tlv(struct sk_buff
> > > *skb, struct ieee80211_sta *sta)
> > >  	he->pkt_ext = 2;
> > >  }
> > >  
> > > +static void
> > > +mt76_connac_mcu_sta_he_tlv_v2(struct sk_buff *skb, struct
> > > ieee80211_sta *sta)
> > 
> > Is this tlv available just for 7921 fw? If so I guess we should add
> > it just for
> > it since mt76_connac_mcu_sta_tlv is used even by other chipsets.
> > 
> > Regards,
> > Lorenzo
> > 
> 
> For now, mt76_connac_mcu_sta_he_tlv_v2() would be used for mt7921 only,
> not for other chips. However, it would be used for all next-generation
> chipsets. I propose to put it here and we will take this API in new
> chip porting.

I am fine with it, I was thinking just to not introduce regression on previous
chips.

Regards,
Lorenzo

> 
> Regards,
> Deren
> 
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]