From: Simon Horman <simon.horman@corigine.com>
To: Doug Brown <doug@schmorgal.com>
Cc: Kalle Valo <kvalo@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Dan Williams <dcbw@redhat.com>,
libertas-dev@lists.infradead.org, linux-wireless@vger.kernel.org,
netdev@vger.kernel.org
Subject: Re: [PATCH v4 0/4] wifi: libertas: IE handling fixes
Date: Mon, 23 Jan 2023 09:06:03 +0100 [thread overview]
Message-ID: <Y84/69P2y84WVWok@corigine.com> (raw)
In-Reply-To: <20230123053132.30710-1-doug@schmorgal.com>
On Sun, Jan 22, 2023 at 09:31:28PM -0800, Doug Brown wrote:
> This series implements two fixes for the libertas driver that restore
> compatibility with modern wpa_supplicant versions, and adds (or at least
> improves) support for WPS in the process.
>
> 1) Better handling of the RSN/WPA IE in association requests:
> The previous logic was always just grabbing the first one, and didn't
> handle multiple IEs properly, which wpa_supplicant adds nowadays.
>
> 2) Support for IEs in scan requests:
> Modern wpa_supplicant always adds an "extended capabilities" IE,
> which violates max_scan_ie_len in this driver. Go ahead and allow
> scan IEs, and handle WPS based on the info that Dan provided.
>
> These changes have been tested on a Marvell PXA168-based device with a
> Marvell 88W8686 Wi-Fi chipset. I've confirmed that with these changes
> applied, modern wpa_supplicant versions connect properly and WPS also
> works correctly (tested with "wpa_cli -i wlan0 wps_pbc any").
Thanks,
this looks good to me. So, FWIIW,
Reviewed-by: Simon Horman <simon.horman@corigine.com>
next prev parent reply other threads:[~2023-01-23 8:06 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-23 5:31 [PATCH v4 0/4] wifi: libertas: IE handling fixes Doug Brown
2023-01-23 5:31 ` [PATCH v4 1/4] wifi: libertas: fix code style in Marvell structs Doug Brown
2023-02-13 15:14 ` Kalle Valo
2023-01-23 5:31 ` [PATCH v4 2/4] wifi: libertas: only add RSN/WPA IE in lbs_add_wpa_tlv Doug Brown
2023-01-23 5:31 ` [PATCH v4 3/4] wifi: libertas: add new TLV type for WPS enrollee IE Doug Brown
2023-01-23 5:31 ` [PATCH v4 4/4] wifi: libertas: add support for WPS enrollee IE in probe requests Doug Brown
2023-01-23 8:06 ` Simon Horman [this message]
2023-01-24 18:24 ` [PATCH v4 0/4] wifi: libertas: IE handling fixes Dan Williams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y84/69P2y84WVWok@corigine.com \
--to=simon.horman@corigine.com \
--cc=davem@davemloft.net \
--cc=dcbw@redhat.com \
--cc=doug@schmorgal.com \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=kvalo@kernel.org \
--cc=libertas-dev@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).