public inbox for linux-wireless@vger.kernel.org
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@oracle.com>
To: shayne.chen@mediatek.com
Cc: linux-wireless@vger.kernel.org
Subject: [bug report] mt76: mt7915: add support for continuous tx in testmode
Date: Wed, 10 Feb 2021 14:06:49 +0300	[thread overview]
Message-ID: <YCO+SaK0nJvCG5J5@mwanda> (raw)

Hello Shayne Chen,

The patch 3f0caa3cbf94: "mt76: mt7915: add support for continuous tx
in testmode" from Jan 5, 2021, leads to the following static checker
warning:

	drivers/net/wireless/mediatek/mt76/mt7915/testmode.c:597 mt7915_tm_set_tx_cont()
	error: uninitialized symbol 'mode'.

drivers/net/wireless/mediatek/mt76/mt7915/testmode.c
   583                  break;
   584          case MT76_TM_TX_MODE_HE_EXT_SU:
   585                  mode = MT_PHY_TYPE_HE_EXT_SU;
   586                  break;
   587          case MT76_TM_TX_MODE_HE_TB:
   588                  mode = MT_PHY_TYPE_HE_TB;
   589                  break;
   590          case MT76_TM_TX_MODE_HE_MU:
   591                  mode = MT_PHY_TYPE_HE_MU;
   592                  break;
   593          default:

"mode" is uninitialized on the default path.

   594                  break;
   595          }
   596  
   597          rateval =  mode << 6 | rate_idx;
                           ^^^^^^^^^

   598          tx_cont->rateval = cpu_to_le16(rateval);
   599  
   600  out:
   601          if (!en) {
   602                  int ret;
   603  

regards,
dan carpenter

             reply	other threads:[~2021-02-10 11:09 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-10 11:06 Dan Carpenter [this message]
2021-02-11  9:01 ` [bug report] mt76: mt7915: add support for continuous tx in testmode Lorenzo Bianconi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YCO+SaK0nJvCG5J5@mwanda \
    --to=dan.carpenter@oracle.com \
    --cc=linux-wireless@vger.kernel.org \
    --cc=shayne.chen@mediatek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox