Re: [PATCH] ath9k: Fix error check in ath9k_hw_read_revisions() for PCI devices

[Lorenzo Bianconi <lorenzo@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 1132 bytes --]

> Toke Høiland-Jørgensen <toke@redhat.com> writes:
> 
> >> When the error check in ath9k_hw_read_revisions() was added, it checked for
> >> -EIO which is what ath9k_regread() in the ath9k_htc driver uses. However,
> >> for plain ath9k, the register read function uses ioread32(), which just
> >> returns -1 on error. So if such a read fails, it still gets passed through
> >> and ends up as a weird mac revision in the log output.
> >>
> >> Fix this by changing ath9k_regread() to return -1 on error like ioread32()
> >> does, and fix the error check to look for that instead of -EIO.
> >>
> >> Fixes: 2f90c7e5d094 ("ath9k: Check for errors when reading SREV register")
> >> Signed-off-by: Toke Høiland-Jørgensen <toke@redhat.com>
> >
> > Hi Kalle
> >
> > This patch is merged as "deferred" in patchwork - what's up with that?
> 
> Just lack of time on my part. Reviewed-by tags would help a lot :)

Reviewed-by: Lorenzo Bianconi <lorenzo@kernel.org>

> 
> -- 
> https://patchwork.kernel.org/project/linux-wireless/list/
> 
> https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]