From: Lorenzo Bianconi <lorenzo.bianconi@redhat.com>
To: Lorenzo Bianconi <lorenzo@kernel.org>
Cc: nbd@nbd.name, linux-wireless@vger.kernel.org, sean.wang@mediatek.com
Subject: Re: [PATCH] mt76: mt7921: get rid of mt7921_dma_cleanup
Date: Tue, 13 Apr 2021 10:27:11 +0200 [thread overview]
Message-ID: <YHVV3xtrPueZriNR@lore-desk> (raw)
In-Reply-To: <a685211cdac6d961744cbbc6c9af54c177023e95.1618301684.git.lorenzo@kernel.org>
[-- Attachment #1: Type: text/plain, Size: 2219 bytes --]
> Remove mt7921_dma_cleanup routine since it is no longer used
>
> Signed-off-by: Lorenzo Bianconi <lorenzo@kernel.org>
> ---
> .../net/wireless/mediatek/mt76/mt7921/dma.c | 23 -------------------
> .../wireless/mediatek/mt76/mt7921/mt7921.h | 1 -
> 2 files changed, 24 deletions(-)
Hi Felix,
please ignore this patch, we need mt7921_dma_cleanup unloading the module.
Regards,
Lorenzo
>
> diff --git a/drivers/net/wireless/mediatek/mt76/mt7921/dma.c b/drivers/net/wireless/mediatek/mt76/mt7921/dma.c
> index 992faf82ad09..14e694563a89 100644
> --- a/drivers/net/wireless/mediatek/mt76/mt7921/dma.c
> +++ b/drivers/net/wireless/mediatek/mt76/mt7921/dma.c
> @@ -331,26 +331,3 @@ int mt7921_dma_init(struct mt7921_dev *dev)
>
> return 0;
> }
> -
> -void mt7921_dma_cleanup(struct mt7921_dev *dev)
> -{
> - /* disable */
> - mt76_clear(dev, MT_WFDMA0_GLO_CFG,
> - MT_WFDMA0_GLO_CFG_TX_DMA_EN |
> - MT_WFDMA0_GLO_CFG_RX_DMA_EN |
> - MT_WFDMA0_GLO_CFG_CSR_DISP_BASE_PTR_CHAIN_EN |
> - MT_WFDMA0_GLO_CFG_OMIT_TX_INFO |
> - MT_WFDMA0_GLO_CFG_OMIT_RX_INFO |
> - MT_WFDMA0_GLO_CFG_OMIT_RX_INFO_PFET2);
> -
> - /* reset */
> - mt76_clear(dev, MT_WFDMA0_RST,
> - MT_WFDMA0_RST_DMASHDL_ALL_RST |
> - MT_WFDMA0_RST_LOGIC_RST);
> -
> - mt76_set(dev, MT_WFDMA0_RST,
> - MT_WFDMA0_RST_DMASHDL_ALL_RST |
> - MT_WFDMA0_RST_LOGIC_RST);
> -
> - mt76_dma_cleanup(&dev->mt76);
> -}
> diff --git a/drivers/net/wireless/mediatek/mt76/mt7921/mt7921.h b/drivers/net/wireless/mediatek/mt76/mt7921/mt7921.h
> index e3d83d3d954c..1e70c749bbf3 100644
> --- a/drivers/net/wireless/mediatek/mt76/mt7921/mt7921.h
> +++ b/drivers/net/wireless/mediatek/mt76/mt7921/mt7921.h
> @@ -225,7 +225,6 @@ int mt7921_eeprom_get_target_power(struct mt7921_dev *dev,
> void mt7921_eeprom_init_sku(struct mt7921_dev *dev);
> int mt7921_dma_init(struct mt7921_dev *dev);
> void mt7921_dma_prefetch(struct mt7921_dev *dev);
> -void mt7921_dma_cleanup(struct mt7921_dev *dev);
> int mt7921_run_firmware(struct mt7921_dev *dev);
> int mt7921_mcu_init(struct mt7921_dev *dev);
> int mt7921_mcu_add_bss_info(struct mt7921_phy *phy,
> --
> 2.30.2
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
prev parent reply other threads:[~2021-04-13 8:27 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-13 8:15 [PATCH] mt76: mt7921: get rid of mt7921_dma_cleanup Lorenzo Bianconi
2021-04-13 8:27 ` Lorenzo Bianconi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YHVV3xtrPueZriNR@lore-desk \
--to=lorenzo.bianconi@redhat.com \
--cc=linux-wireless@vger.kernel.org \
--cc=lorenzo@kernel.org \
--cc=nbd@nbd.name \
--cc=sean.wang@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox