From: Dan Carpenter <dan.carpenter@oracle.com>
To: ryder.lee@mediatek.com
Cc: linux-wireless@vger.kernel.org, linux-mediatek@lists.infradead.org
Subject: [bug report] mt76: mt7615: fix TSF configuration
Date: Wed, 21 Apr 2021 16:17:31 +0300 [thread overview]
Message-ID: <YIAl62mky03Byme+@mwanda> (raw)
Hello Ryder Lee,
This is a semi-automatic email about new static checker warnings.
The patch a4a5a430b076: "mt76: mt7615: fix TSF configuration" from
Feb 23, 2021, leads to the following Smatch complaint:
drivers/net/wireless/mediatek/mt76/mt7615/usb_sdio.c:74 mt7663_usb_sdio_set_rates()
warn: variable dereferenced before check 'sta' (see line 70)
drivers/net/wireless/mediatek/mt76/mt7615/usb_sdio.c
69 u32 w5, w27, addr, val;
70 u16 idx = sta->vif->mt76.omac_idx;
^^^^^^^^^^^^^^
The patch adds a new dereference
71
72 lockdep_assert_held(&dev->mt76.mutex);
73
74 if (!sta)
^^^
The old code checks for NULL
75 return -EINVAL;
76
regards,
dan carpenter
reply other threads:[~2021-04-21 13:19 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YIAl62mky03Byme+@mwanda \
--to=dan.carpenter@oracle.com \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=ryder.lee@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).