From: Greg KH <gregkh@linuxfoundation.org>
To: Emmanuel Grumbach <emmanuel.grumbach@intel.com>
Cc: linux-wireless@vger.kernel.org, johannes.berg@intel.com,
tomas.winkler@intel.com, luciano.coelho@intel.com,
Ayala Beker <ayala.beker@intel.com>
Subject: Re: [PATCH v2 2/3] iwlwifi: mei: add the driver to allow cooperation with CSME
Date: Thu, 13 May 2021 20:56:09 +0200 [thread overview]
Message-ID: <YJ12SaLoO40u3lG5@kroah.com> (raw)
In-Reply-To: <20210420172755.12178-2-emmanuel.grumbach@intel.com>
On Tue, Apr 20, 2021 at 08:27:54PM +0300, Emmanuel Grumbach wrote:
> +#define ROUND_UP_TO(x, y) (((x) + (y) - 1) / (y) * (y))
What's wrong with roundup() that the kernel provides?
Please don't reinvent things we already have :(
thanks,
greg k-h
next prev parent reply other threads:[~2021-05-13 18:56 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-12 12:43 [PATCH RESEND 1/3] mei: bus: add client dma interface Emmanuel Grumbach
2021-04-12 12:43 ` [PATCH RESEND 2/3] iwlwifi: mei: add the driver to allow cooperation with CSME Emmanuel Grumbach
2021-04-12 13:06 ` Greg KH
2021-04-12 13:44 ` Grumbach, Emmanuel
2021-04-12 14:18 ` Greg KH
2021-04-12 14:29 ` Grumbach, Emmanuel
2021-04-12 14:35 ` Greg KH
2021-04-12 14:46 ` Grumbach, Emmanuel
2021-04-12 15:09 ` Greg KH
2021-04-12 12:43 ` [PATCH RESEND 3/3] iwlwifi: integrate with iwlmei Emmanuel Grumbach
2021-04-12 13:09 ` Greg KH
2021-04-12 13:09 ` [PATCH RESEND 1/3] mei: bus: add client dma interface Greg KH
2021-04-20 17:27 ` [PATCH v2 " Emmanuel Grumbach
2021-04-20 17:27 ` [PATCH v2 2/3] iwlwifi: mei: add the driver to allow cooperation with CSME Emmanuel Grumbach
2021-05-13 18:56 ` Greg KH [this message]
2021-04-20 17:27 ` [PATCH v2 3/3] iwlwifi: integrate with iwlmei Emmanuel Grumbach
2021-05-12 5:49 ` [PATCH v2 1/3] mei: bus: add client dma interface Emmanuel Grumbach
2021-05-12 6:02 ` Greg KH
2021-05-13 18:57 ` Greg KH
2021-05-21 8:51 ` Luca Coelho
2021-05-21 8:55 ` Coelho, Luciano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YJ12SaLoO40u3lG5@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=ayala.beker@intel.com \
--cc=emmanuel.grumbach@intel.com \
--cc=johannes.berg@intel.com \
--cc=linux-wireless@vger.kernel.org \
--cc=luciano.coelho@intel.com \
--cc=tomas.winkler@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).