linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Lorenzo Bianconi <lorenzo@kernel.org>
To: nbd@nbd.name, johannes@sipsolutions.net
Cc: linux-wireless@vger.kernel.org, lorenzo.bianconi@redhat.com,
	ryder.lee@mediatek.com, chui-hao.chiu@mediatek.com
Subject: Re: [PATCH mac80211-next 7/7] mt76: mt7915: add twt_stats knob in debugfs
Date: Wed, 4 Aug 2021 10:35:44 +0200	[thread overview]
Message-ID: <YQpRYH3AuzAHQwq3@lore-desk> (raw)
In-Reply-To: <c15deb39ada1d7f642a7cf7bf21a60e84dde240d.1628062233.git.lorenzo@kernel.org>

[-- Attachment #1: Type: text/plain, Size: 2143 bytes --]

> Introduce twt_stats knob in debugfs in order to dump established
> agreements
> 
> Tested-by: Peter Chiu <chui-hao.chiu@mediatek.com>
> Signed-off-by: Lorenzo Bianconi <lorenzo@kernel.org>
> ---
>  .../wireless/mediatek/mt76/mt7915/debugfs.c   | 28 +++++++++++++++++++
>  1 file changed, 28 insertions(+)
> 
> diff --git a/drivers/net/wireless/mediatek/mt76/mt7915/debugfs.c b/drivers/net/wireless/mediatek/mt76/mt7915/debugfs.c
> index 1a48b09d0cb7..5ed329f720d6 100644
> --- a/drivers/net/wireless/mediatek/mt76/mt7915/debugfs.c
> +++ b/drivers/net/wireless/mediatek/mt76/mt7915/debugfs.c
> @@ -335,6 +335,32 @@ mt7915_read_rate_txpower(struct seq_file *s, void *data)
>  	return 0;
>  }
>  
> +static int
> +mt7915_twt_stats(struct seq_file *s, void *data)
> +{
> +	struct mt7915_dev *dev = dev_get_drvdata(s->private);
> +	struct mt7915_twt_flow *iter;
> +
> +	rcu_read_lock();
> +
> +	seq_puts(s, "     wcid |       id |    flags |      exp | mantissa");
> +	seq_puts(s, " | duration |            tsf |\n");
> +	list_for_each_entry_rcu(iter, &dev->twt_list, list)
> +		seq_printf(s,
> +			"%9d | %8d | %5c%c%c%c | %8d | %8d | %8d | %14lld |\n",
> +			iter->wcid, iter->id,
> +			iter->sched ? 's' : 'u',
> +			iter->protection ? 'p' : '-',
> +			iter->trigger ? 't' : '-',
> +			iter->flowtype ? '-' : 'a',
> +			iter->exp, iter->mantissa,
> +			iter->duration, iter->tsf);
> +
> +	rcu_read_lock();

ops, there is a typo here, I will fix it in v2. I will wait for some feedbacks
on v1 first.

Regards,
Lorenzo

> +
> +	return 0;
> +}
> +
>  int mt7915_init_debugfs(struct mt7915_dev *dev)
>  {
>  	struct dentry *dir;
> @@ -352,6 +378,8 @@ int mt7915_init_debugfs(struct mt7915_dev *dev)
>  	debugfs_create_file("implicit_txbf", 0600, dir, dev,
>  			    &fops_implicit_txbf);
>  	debugfs_create_u32("dfs_hw_pattern", 0400, dir, &dev->hw_pattern);
> +	debugfs_create_devm_seqfile(dev->mt76.dev, "twt_stats", dir,
> +				    mt7915_twt_stats);
>  	/* test knobs */
>  	debugfs_create_file("radar_trigger", 0200, dir, dev,
>  			    &fops_radar_trigger);
> -- 
> 2.31.1
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

      reply	other threads:[~2021-08-04  8:35 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-04  7:36 [PATCH mac80211-next 0/7] introduce individual TWT support in AP mode Lorenzo Bianconi
2021-08-04  7:36 ` [PATCH mac80211-next 1/7] mac80211: add twt ie in ieee80211_mgmt structure Lorenzo Bianconi
2021-08-04  7:36 ` [PATCH mac80211-next 2/7] mac80211: introduce individual TWT support in AP mode Lorenzo Bianconi
2021-08-04  7:36 ` [PATCH mac80211-next 3/7] mt76: mt7915: introduce __mt7915_get_tsf routine Lorenzo Bianconi
2021-08-04  7:36 ` [PATCH mac80211-next 4/7] mt76: mt7915: introduce mt7915_mcu_twt_agrt_update mcu command Lorenzo Bianconi
2021-08-04  7:36 ` [PATCH mac80211-next 5/7] mt76: mt7915: introduce mt7915_mac_add_twt_setup routine Lorenzo Bianconi
2021-08-04  7:36 ` [PATCH mac80211-next 6/7] mt76: mt7915: enable twt responder capability Lorenzo Bianconi
2021-08-04  7:36 ` [PATCH mac80211-next 7/7] mt76: mt7915: add twt_stats knob in debugfs Lorenzo Bianconi
2021-08-04  8:35   ` Lorenzo Bianconi [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YQpRYH3AuzAHQwq3@lore-desk \
    --to=lorenzo@kernel.org \
    --cc=chui-hao.chiu@mediatek.com \
    --cc=johannes@sipsolutions.net \
    --cc=linux-wireless@vger.kernel.org \
    --cc=lorenzo.bianconi@redhat.com \
    --cc=nbd@nbd.name \
    --cc=ryder.lee@mediatek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).