From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E95E1C4338F for ; Wed, 4 Aug 2021 16:21:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C652960FC4 for ; Wed, 4 Aug 2021 16:21:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236575AbhHDQWB (ORCPT ); Wed, 4 Aug 2021 12:22:01 -0400 Received: from mail.kernel.org ([198.145.29.99]:43632 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234064AbhHDQWB (ORCPT ); Wed, 4 Aug 2021 12:22:01 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id E438860F94; Wed, 4 Aug 2021 16:21:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1628094108; bh=3KghkMAaEVvO0bpaXEGPMyBaiRpeQXsRfgm2tvbKbFc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=etP3HeEVLchoQYPkz3OdxNNwoQofy2/aGrtIeOZGh2QzxVAcfDYwx22PX+X3JT3Qn lskhxWVyibhOmVbaxw5EzjmndGfFD5/GjZjdrerWa/SOmaG/ajlIiFIIBEy/cYVskr Q+k4AtYTnndrzra1dR/j7q83T4kM/syMtjFA88pLlkn18DAAAVmw18heD4clqEINxT KK3+RRYNDjJAZPyPtMzJvY4AqwBqhKST4nh9M8B7jjdIhy/IZF/mQamW2bW65srG9M pzL31t1SEcYTDxMvWvjgjrV2lEz1/pd4F2ws9zu2tbP6QT4cFlPDwurEXbPTiBjvdj N4Gehi8pjP3kg== Date: Wed, 4 Aug 2021 18:21:43 +0200 From: Lorenzo Bianconi To: YN Chen Cc: Felix Fietkau , Lorenzo Bianconi , Sean Wang , Soul Huang , Leon Yen , Eric-SY Chang , Deren Wu , KM Lin , Robin Chiu , CH Yeh , Posh Sun , Eric Liang , Stella Chang , jemele@google.com, yenlinlai@google.com, linux-wireless , linux-mediatek Subject: Re: [PATCH v2] mt76: mt7921: enable VO tx aggregation Message-ID: References: <889fc1f28a8402f82cb83243af4916c3311c3eb1.1628072837.git.deren.wu@mediatek.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="vNJtZXllMJRnjY3o" Content-Disposition: inline In-Reply-To: <889fc1f28a8402f82cb83243af4916c3311c3eb1.1628072837.git.deren.wu@mediatek.com> Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org --vNJtZXllMJRnjY3o Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable > From: Deren Wu >=20 > Avoid throughput drop in VO streaming, enable TX BA by default. 802.11 ampdu is disabled for VO traffic in order to avoid introducing delay= I guess. Regards, Lorenzo >=20 > Signed-off-by: Deren Wu > Signed-off-by: YN Chen > --- > v1 -> v2 : commit format adjustment > --- > drivers/net/wireless/mediatek/mt76/mt7921/mac.c | 2 -- > 1 file changed, 2 deletions(-) >=20 > diff --git a/drivers/net/wireless/mediatek/mt76/mt7921/mac.c b/drivers/ne= t/wireless/mediatek/mt76/mt7921/mac.c > index 296e0f7a1d14..1be1e07ae786 100644 > --- a/drivers/net/wireless/mediatek/mt76/mt7921/mac.c > +++ b/drivers/net/wireless/mediatek/mt76/mt7921/mac.c > @@ -913,8 +913,6 @@ mt7921_tx_check_aggr(struct ieee80211_sta *sta, __le3= 2 *txwi) > return; > =20 > tid =3D FIELD_GET(MT_TXD1_TID, le32_to_cpu(txwi[1])); > - if (tid >=3D 6) /* skip VO queue */ > - return; > =20 > val =3D le32_to_cpu(txwi[2]); > fc =3D FIELD_GET(MT_TXD2_FRAME_TYPE, val) << 2 | > --=20 > 2.25.1 >=20 --vNJtZXllMJRnjY3o Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQTquNwa3Txd3rGGn7Y6cBh0uS2trAUCYQq+lAAKCRA6cBh0uS2t rOWPAQD9D952emRHoqvknYacCFHvccY6iDjStYHSolG6jiE/VQEAq7k5f4u7Sh58 MG0GaWDIbZ4/javYeZ2HrTAQF+R+wAA= =fERJ -----END PGP SIGNATURE----- --vNJtZXllMJRnjY3o--