From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A3C0FC4338F for ; Wed, 18 Aug 2021 09:18:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8322260F39 for ; Wed, 18 Aug 2021 09:18:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231665AbhHRJTH (ORCPT ); Wed, 18 Aug 2021 05:19:07 -0400 Received: from mail.kernel.org ([198.145.29.99]:56900 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231660AbhHRJTG (ORCPT ); Wed, 18 Aug 2021 05:19:06 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id B2C2461053; Wed, 18 Aug 2021 09:18:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1629278312; bh=friwccb5Ts3sorbhemyaGBt/b1Dkjnx6Ia4rZ7X9Ffc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=LbTzH0gcLS+3ThzJSajlXaufNyCRrCdbRW2VdnqSgFAabLVKWpeo3uy4Y1P+iGsvI BmvUNTLQ/0sf9x5YGkgY7PXfU1NaAaeZP98gQ1RL9JPFrZwALkiMohZQ2yf71RB33a QdeI2VV+VX1jNTWlwH0DFP6hpx9FF/tAhr6O4odg= Date: Wed, 18 Aug 2021 11:18:29 +0200 From: Greg KH To: Pali =?iso-8859-1?Q?Roh=E1r?= Cc: stable@vger.kernel.org, Sasha Levin , Kalle Valo , linux-wireless@vger.kernel.org Subject: Re: Backporting CVE-2020-3702 ath9k patches to stable Message-ID: References: <20210818084859.vcs4vs3yd6zetmyt@pali> <20210818091027.2mhqrhg5pcq2bagt@pali> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20210818091027.2mhqrhg5pcq2bagt@pali> Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On Wed, Aug 18, 2021 at 11:10:27AM +0200, Pali Rohár wrote: > On Wednesday 18 August 2021 11:02:47 Greg KH wrote: > > On Wed, Aug 18, 2021 at 10:48:59AM +0200, Pali Rohár wrote: > > > Hello! I would like to request for backporting following ath9k commits > > > which are fixing CVE-2020-3702 issue. > > > > > > 56c5485c9e44 ("ath: Use safer key clearing with key cache entries") > > > 73488cb2fa3b ("ath9k: Clear key cache explicitly on disabling hardware") > > > d2d3e36498dd ("ath: Export ath_hw_keysetmac()") > > > 144cd24dbc36 ("ath: Modify ath_key_delete() to not need full key entry") > > > ca2848022c12 ("ath9k: Postpone key cache entry deletion for TXQ frames reference it") > > > > > > See also: > > > https://lore.kernel.org/linux-wireless/87o8hvlx5g.fsf@codeaurora.org/ > > > > > > This CVE-2020-3702 issue affects ath9k driver in stable kernel versions. > > > And due to this issue Qualcomm suggests to not use open source ath9k > > > driver and instead to use their proprietary driver which do not have > > > this issue. > > > > > > Details about CVE-2020-3702 are described on the ESET blog post: > > > https://www.welivesecurity.com/2020/08/06/beyond-kr00k-even-more-wifi-chips-vulnerable-eavesdropping/ > > > > > > Two months ago ESET tested above mentioned commits applied on top of > > > 4.14 stable tree and confirmed that issue cannot be reproduced anymore > > > with those patches. Commits were applied cleanly on top of 4.14 stable > > > tree without need to do any modification. > > > > What stable tree(s) do you want to see these go into? > > Commits were introduced in 5.12, so it should go to all stable trees << 5.12 > > > And what order are the above commits to be applied in, top-to-bottom or > > bottom-to-top? > > Same order in which were applied in 5.12. So first commit to apply is > 56c5485c9e44, then 73488cb2fa3b and so on... (from top of the email to > the bottom of email). Great, all now queued up. Sad that qcom didn't want to do this themselves :( greg k-h