From: Lorenzo Bianconi <lorenzo.bianconi@redhat.com>
To: sean.wang@mediatek.com
Cc: nbd@nbd.name, Soul.Huang@mediatek.com, YN.Chen@mediatek.com,
Leon.Yen@mediatek.com, Eric-SY.Chang@mediatek.com,
Deren.Wu@mediatek.com, km.lin@mediatek.com,
robin.chiu@mediatek.com, Eddie.Chen@mediatek.com,
ch.yeh@mediatek.com, posh.sun@mediatek.com,
ted.huang@mediatek.com, Eric.Liang@mediatek.com,
Stella.Chang@mediatek.com, steve.lee@mediatek.com,
jemele@google.com, shawnku@google.com,
linux-wireless@vger.kernel.org,
linux-mediatek@lists.infradead.org
Subject: Re: [PATCH v1 10/16] mt76: mt7921: use physical addr to unify register access
Date: Wed, 15 Sep 2021 15:26:15 +0200 [thread overview]
Message-ID: <YUH0d5nPfS+6uejD@lore-desk> (raw)
In-Reply-To: <856edf387e8e7f444d0eaf95ffac0616571146d1.1631667941.git.objelf@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 7978 bytes --]
On Sep 15, Sean Wang wrote:
> From: Sean Wang <sean.wang@mediatek.com>
>
> Use physical address to unify the register access and reorder the
> entries in fixed_map table to accelerate the address lookup for
> MT7921e.
>
> Tested-by: Deren Wu <deren.wu@mediatek.com>
> Signed-off-by: Sean Wang <sean.wang@mediatek.com>
> ---
> .../net/wireless/mediatek/mt76/mt7921/dma.c | 19 ++++++++--------
> .../net/wireless/mediatek/mt76/mt7921/regs.h | 22 +++++++++----------
> 2 files changed, 21 insertions(+), 20 deletions(-)
>
> diff --git a/drivers/net/wireless/mediatek/mt76/mt7921/dma.c b/drivers/net/wireless/mediatek/mt76/mt7921/dma.c
> index be24241fb8e6..f31c4aef8b27 100644
> --- a/drivers/net/wireless/mediatek/mt76/mt7921/dma.c
> +++ b/drivers/net/wireless/mediatek/mt76/mt7921/dma.c
> @@ -85,6 +85,14 @@ static u32 __mt7921_reg_addr(struct mt7921_dev *dev, u32 addr)
> u32 mapped;
> u32 size;
> } fixed_map[] = {
> + { 0x820d0000, 0x30000, 0x10000 }, /* WF_LMAC_TOP (WF_WTBLON) */
> + { 0x820ed000, 0x24800, 0x0800 }, /* WF_LMAC_TOP BN0 (WF_MIB) */
> + { 0x820e4000, 0x21000, 0x0400 }, /* WF_LMAC_TOP BN0 (WF_TMAC) */
> + { 0x820e7000, 0x21e00, 0x0200 }, /* WF_LMAC_TOP BN0 (WF_DMA) */
> + { 0x820eb000, 0x24200, 0x0400 }, /* WF_LMAC_TOP BN0 (WF_LPON) */
> + { 0x820e2000, 0x20800, 0x0400 }, /* WF_LMAC_TOP BN0 (WF_AGG) */
> + { 0x820e3000, 0x20c00, 0x0400 }, /* WF_LMAC_TOP BN0 (WF_ARB) */
> + { 0x820e5000, 0x21400, 0x0800 }, /* WF_LMAC_TOP BN0 (WF_RMAC) */
> { 0x00400000, 0x80000, 0x10000}, /* WF_MCU_SYSRAM */
> { 0x00410000, 0x90000, 0x10000}, /* WF_MCU_SYSRAM (configure register) */
> { 0x40000000, 0x70000, 0x10000}, /* WF_UMAC_SYSRAM */
not related to this patch, but since you are chaing it can you please add a
space at the end of the line above? Thanks :)
Regards,
Lorenzo
> @@ -99,22 +107,15 @@ static u32 __mt7921_reg_addr(struct mt7921_dev *dev, u32 addr)
> { 0x81020000, 0xc0000, 0x10000 }, /* WF_TOP_MISC_ON */
> { 0x820c0000, 0x08000, 0x4000 }, /* WF_UMAC_TOP (PLE) */
> { 0x820c8000, 0x0c000, 0x2000 }, /* WF_UMAC_TOP (PSE) */
> - { 0x820cc000, 0x0e000, 0x2000 }, /* WF_UMAC_TOP (PP) */
> + { 0x820cc000, 0x0e000, 0x1000 }, /* WF_UMAC_TOP (PP) */
> + { 0x820cd000, 0x0f000, 0x1000 }, /* WF_MDP_TOP */
> { 0x820ce000, 0x21c00, 0x0200 }, /* WF_LMAC_TOP (WF_SEC) */
> { 0x820cf000, 0x22000, 0x1000 }, /* WF_LMAC_TOP (WF_PF) */
> - { 0x820d0000, 0x30000, 0x10000 }, /* WF_LMAC_TOP (WF_WTBLON) */
> { 0x820e0000, 0x20000, 0x0400 }, /* WF_LMAC_TOP BN0 (WF_CFG) */
> { 0x820e1000, 0x20400, 0x0200 }, /* WF_LMAC_TOP BN0 (WF_TRB) */
> - { 0x820e2000, 0x20800, 0x0400 }, /* WF_LMAC_TOP BN0 (WF_AGG) */
> - { 0x820e3000, 0x20c00, 0x0400 }, /* WF_LMAC_TOP BN0 (WF_ARB) */
> - { 0x820e4000, 0x21000, 0x0400 }, /* WF_LMAC_TOP BN0 (WF_TMAC) */
> - { 0x820e5000, 0x21400, 0x0800 }, /* WF_LMAC_TOP BN0 (WF_RMAC) */
> - { 0x820e7000, 0x21e00, 0x0200 }, /* WF_LMAC_TOP BN0 (WF_DMA) */
> { 0x820e9000, 0x23400, 0x0200 }, /* WF_LMAC_TOP BN0 (WF_WTBLOFF) */
> { 0x820ea000, 0x24000, 0x0200 }, /* WF_LMAC_TOP BN0 (WF_ETBF) */
> - { 0x820eb000, 0x24200, 0x0400 }, /* WF_LMAC_TOP BN0 (WF_LPON) */
> { 0x820ec000, 0x24600, 0x0200 }, /* WF_LMAC_TOP BN0 (WF_INT) */
> - { 0x820ed000, 0x24800, 0x0800 }, /* WF_LMAC_TOP BN0 (WF_MIB) */
> { 0x820f0000, 0xa0000, 0x0400 }, /* WF_LMAC_TOP BN1 (WF_CFG) */
> { 0x820f1000, 0xa0600, 0x0200 }, /* WF_LMAC_TOP BN1 (WF_TRB) */
> { 0x820f2000, 0xa0800, 0x0400 }, /* WF_LMAC_TOP BN1 (WF_AGG) */
> diff --git a/drivers/net/wireless/mediatek/mt76/mt7921/regs.h b/drivers/net/wireless/mediatek/mt76/mt7921/regs.h
> index 26fb11823762..cb6069024320 100644
> --- a/drivers/net/wireless/mediatek/mt76/mt7921/regs.h
> +++ b/drivers/net/wireless/mediatek/mt76/mt7921/regs.h
> @@ -14,7 +14,7 @@
> #define MT_MCU_INT_EVENT_SER_TRIGGER BIT(2)
> #define MT_MCU_INT_EVENT_RESET_DONE BIT(3)
>
> -#define MT_PLE_BASE 0x8000
> +#define MT_PLE_BASE 0x820c0000
> #define MT_PLE(ofs) (MT_PLE_BASE + (ofs))
>
> #define MT_PLE_FL_Q0_CTRL MT_PLE(0x1b0)
> @@ -26,7 +26,7 @@
> ((n) << 2))
> #define MT_PLE_AMSDU_PACK_MSDU_CNT(n) MT_PLE(0x10e0 + ((n) << 2))
>
> -#define MT_MDP_BASE 0xf000
> +#define MT_MDP_BASE 0x820cd000
> #define MT_MDP(ofs) (MT_MDP_BASE + (ofs))
>
> #define MT_MDP_DCR0 MT_MDP(0x000)
> @@ -49,7 +49,7 @@
> #define MT_MDP_TO_WM 1
>
> /* TMAC: band 0(0x21000), band 1(0xa1000) */
> -#define MT_WF_TMAC_BASE(_band) ((_band) ? 0xa1000 : 0x21000)
> +#define MT_WF_TMAC_BASE(_band) ((_band) ? 0x820f4000 : 0x820e4000)
> #define MT_WF_TMAC(_band, ofs) (MT_WF_TMAC_BASE(_band) + (ofs))
>
> #define MT_TMAC_TCR0(_band) MT_WF_TMAC(_band, 0)
> @@ -74,7 +74,7 @@
> #define MT_TMAC_TRCR0(_band) MT_WF_TMAC(_band, 0x09c)
> #define MT_TMAC_TFCR0(_band) MT_WF_TMAC(_band, 0x1e0)
>
> -#define MT_WF_DMA_BASE(_band) ((_band) ? 0xa1e00 : 0x21e00)
> +#define MT_WF_DMA_BASE(_band) ((_band) ? 0x820f7000 : 0x820e7000)
> #define MT_WF_DMA(_band, ofs) (MT_WF_DMA_BASE(_band) + (ofs))
>
> #define MT_DMA_DCR0(_band) MT_WF_DMA(_band, 0x000)
> @@ -82,7 +82,7 @@
> #define MT_DMA_DCR0_RXD_G5_EN BIT(23)
>
> /* LPON: band 0(0x24200), band 1(0xa4200) */
> -#define MT_WF_LPON_BASE(_band) ((_band) ? 0xa4200 : 0x24200)
> +#define MT_WF_LPON_BASE(_band) ((_band) ? 0x820fb000 : 0x820eb000)
> #define MT_WF_LPON(_band, ofs) (MT_WF_LPON_BASE(_band) + (ofs))
>
> #define MT_LPON_UTTR0(_band) MT_WF_LPON(_band, 0x080)
> @@ -93,7 +93,7 @@
> #define MT_LPON_TCR_SW_WRITE BIT(0)
>
> /* MIB: band 0(0x24800), band 1(0xa4800) */
> -#define MT_WF_MIB_BASE(_band) ((_band) ? 0xa4800 : 0x24800)
> +#define MT_WF_MIB_BASE(_band) ((_band) ? 0x820fd000 : 0x820ed000)
> #define MT_WF_MIB(_band, ofs) (MT_WF_MIB_BASE(_band) + (ofs))
>
> #define MT_MIB_SCR1(_band) MT_WF_MIB(_band, 0x004)
> @@ -142,7 +142,7 @@
> #define MT_MIB_ARNG(_band, n) MT_WF_MIB(_band, 0x0b0 + ((n) << 2))
> #define MT_MIB_ARNCR_RANGE(val, n) (((val) >> ((n) << 3)) & GENMASK(7, 0))
>
> -#define MT_WTBLON_TOP_BASE 0x34000
> +#define MT_WTBLON_TOP_BASE 0x820d4000
> #define MT_WTBLON_TOP(ofs) (MT_WTBLON_TOP_BASE + (ofs))
> #define MT_WTBLON_TOP_WDUCR MT_WTBLON_TOP(0x200)
> #define MT_WTBLON_TOP_WDUCR_GROUP GENMASK(2, 0)
> @@ -152,7 +152,7 @@
> #define MT_WTBL_UPDATE_ADM_COUNT_CLEAR BIT(12)
> #define MT_WTBL_UPDATE_BUSY BIT(31)
>
> -#define MT_WTBL_BASE 0x38000
> +#define MT_WTBL_BASE 0x820d8000
> #define MT_WTBL_LMAC_ID GENMASK(14, 8)
> #define MT_WTBL_LMAC_DW GENMASK(7, 2)
> #define MT_WTBL_LMAC_OFFS(_id, _dw) (MT_WTBL_BASE | \
> @@ -160,7 +160,7 @@
> FIELD_PREP(MT_WTBL_LMAC_DW, _dw))
>
> /* AGG: band 0(0x20800), band 1(0xa0800) */
> -#define MT_WF_AGG_BASE(_band) ((_band) ? 0xa0800 : 0x20800)
> +#define MT_WF_AGG_BASE(_band) ((_band) ? 0x820f2000 : 0x820e2000)
> #define MT_WF_AGG(_band, ofs) (MT_WF_AGG_BASE(_band) + (ofs))
>
> #define MT_AGG_AWSCR0(_band, _n) MT_WF_AGG(_band, 0x05c + (_n) * 4)
> @@ -191,7 +191,7 @@
> #define MT_AGG_ATCR3(_band) MT_WF_AGG(_band, 0x0f4)
>
> /* ARB: band 0(0x20c00), band 1(0xa0c00) */
> -#define MT_WF_ARB_BASE(_band) ((_band) ? 0xa0c00 : 0x20c00)
> +#define MT_WF_ARB_BASE(_band) ((_band) ? 0x820f3000 : 0x820e3000)
> #define MT_WF_ARB(_band, ofs) (MT_WF_ARB_BASE(_band) + (ofs))
>
> #define MT_ARB_SCR(_band) MT_WF_ARB(_band, 0x080)
> @@ -201,7 +201,7 @@
> #define MT_ARB_DRNGR0(_band, _n) MT_WF_ARB(_band, 0x194 + (_n) * 4)
>
> /* RMAC: band 0(0x21400), band 1(0xa1400) */
> -#define MT_WF_RMAC_BASE(_band) ((_band) ? 0xa1400 : 0x21400)
> +#define MT_WF_RMAC_BASE(_band) ((_band) ? 0x820f5000 : 0x820e5000)
> #define MT_WF_RMAC(_band, ofs) (MT_WF_RMAC_BASE(_band) + (ofs))
>
> #define MT_WF_RFCR(_band) MT_WF_RMAC(_band, 0x000)
> --
> 2.25.1
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2021-09-15 13:26 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-15 1:14 [PATCH v1 00/16] Add MT7921 SDIO support sean.wang
2021-09-15 1:14 ` [PATCH v1 01/16] mt76: mt7921: refactor mac.c to be bus independent sean.wang
2021-09-15 13:01 ` Lorenzo Bianconi
2021-09-15 1:14 ` [PATCH v1 02/16] mt76: mt7921: refactor dma.c to be pcie specific sean.wang
2021-09-15 13:03 ` Lorenzo Bianconi
2021-09-15 1:14 ` [PATCH v1 03/16] mt76: mt7921: refactor mcu.c to be bus independent sean.wang
2021-09-15 13:08 ` Lorenzo Bianconi
2021-09-15 1:14 ` [PATCH v1 04/16] mt76: mt7921: refactor init.c " sean.wang
2021-09-15 13:14 ` Lorenzo Bianconi
2021-09-15 1:14 ` [PATCH v1 05/16] mt76: mt7921: add MT7921_COMMON module sean.wang
2021-09-15 1:14 ` [PATCH v1 06/16] mt76: connac: move mcu reg access utility routines in mt76_connac_lib module sean.wang
2021-09-15 1:14 ` [PATCH v1 07/16] mt76: connac: move sdio utility routines in mt76_connac_sdio module sean.wang
2021-09-15 13:20 ` Lorenzo Bianconi
2021-09-15 14:30 ` Lorenzo Bianconi
2021-09-15 1:14 ` [PATCH v1 08/16] mt76: mt7663s: rely on mt76_connac_sdio common library sean.wang
2021-09-15 1:14 ` [PATCH v1 09/16] mt76: mt7921: make all event parser resuable between mt7921s and mt7921e sean.wang
2021-09-15 13:24 ` Lorenzo Bianconi
2021-09-15 13:31 ` Lorenzo Bianconi
2021-09-15 1:14 ` [PATCH v1 10/16] mt76: mt7921: use physical addr to unify register access sean.wang
2021-09-15 13:26 ` Lorenzo Bianconi [this message]
2021-09-15 1:14 ` [PATCH v1 11/16] mt76: connac: extend mt76_connac_sdio module to support CONNAC2 sean.wang
2021-09-15 1:14 ` [PATCH v1 12/16] mt76: connac: extend mcu_get_nic_capability sean.wang
2021-09-15 1:14 ` [PATCH v1 13/16] mt76: mt7921: rely on mcu_get_nic_capability sean.wang
2021-09-15 1:14 ` [PATCH v1 14/16] mt76: mt7921: refactor mt7921_mcu_send_message sean.wang
2021-09-15 1:14 ` [PATCH v1 15/16] mt76: mt7921: introduce mt7921s support sean.wang
2021-09-15 1:14 ` [PATCH v1 16/16] mt76: mt7921s: add reset support sean.wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YUH0d5nPfS+6uejD@lore-desk \
--to=lorenzo.bianconi@redhat.com \
--cc=Deren.Wu@mediatek.com \
--cc=Eddie.Chen@mediatek.com \
--cc=Eric-SY.Chang@mediatek.com \
--cc=Eric.Liang@mediatek.com \
--cc=Leon.Yen@mediatek.com \
--cc=Soul.Huang@mediatek.com \
--cc=Stella.Chang@mediatek.com \
--cc=YN.Chen@mediatek.com \
--cc=ch.yeh@mediatek.com \
--cc=jemele@google.com \
--cc=km.lin@mediatek.com \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=nbd@nbd.name \
--cc=posh.sun@mediatek.com \
--cc=robin.chiu@mediatek.com \
--cc=sean.wang@mediatek.com \
--cc=shawnku@google.com \
--cc=steve.lee@mediatek.com \
--cc=ted.huang@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).