From: Lorenzo Bianconi <lorenzo.bianconi@redhat.com>
To: Shayne Chen <shayne.chen@mediatek.com>
Cc: Felix Fietkau <nbd@nbd.name>,
linux-wireless <linux-wireless@vger.kernel.org>,
Ryder Lee <ryder.lee@mediatek.com>,
Deren Wu <deren.wu@mediatek.com>,
Evelyn Tsai <evelyn.tsai@mediatek.com>,
linux-mediatek <linux-mediatek@lists.infradead.org>
Subject: Re: [PATCH] mt76: mt7921: use correct iftype data on 6GHz cap init
Date: Sat, 27 Nov 2021 15:43:31 +0100 [thread overview]
Message-ID: <YaJEE0gKhZvtBs6n@lore-desk> (raw)
In-Reply-To: <20211126165316.1662-1-shayne.chen@mediatek.com>
[-- Attachment #1: Type: text/plain, Size: 1262 bytes --]
> Set 6GHz cap to iftype data which is matched to the type of
> current interface.
In this case data points to data[idx] since mt7921 supports just
NL80211_IFTYPE_STATION (please note idx = 0 and idx != i).
Anyway this can be an issue in the future when we will add more vif_type.
Maybe we can drop Fixes tag, not sure. Anyway:
Acked-by: Lorenzo Bianconi <lorenzo@kernel.org>
>
> Fixes: 50ac15a511e3 ("mt76: mt7921: add 6GHz support")
> Signed-off-by: Shayne Chen <shayne.chen@mediatek.com>
> ---
> drivers/net/wireless/mediatek/mt76/mt7921/main.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/wireless/mediatek/mt76/mt7921/main.c b/drivers/net/wireless/mediatek/mt76/mt7921/main.c
> index 5a64126..5540b2d 100644
> --- a/drivers/net/wireless/mediatek/mt76/mt7921/main.c
> +++ b/drivers/net/wireless/mediatek/mt76/mt7921/main.c
> @@ -178,7 +178,7 @@ mt7921_init_he_caps(struct mt7921_phy *phy, enum nl80211_band band,
> if (vht_cap->cap & IEEE80211_VHT_CAP_RX_ANTENNA_PATTERN)
> cap |= IEEE80211_HE_6GHZ_CAP_RX_ANTPAT_CONS;
>
> - data->he_6ghz_capa.capa = cpu_to_le16(cap);
> + data[idx].he_6ghz_capa.capa = cpu_to_le16(cap);
> }
> idx++;
> }
> --
> 2.25.1
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
prev parent reply other threads:[~2021-11-27 14:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-26 16:53 [PATCH] mt76: mt7921: use correct iftype data on 6GHz cap init Shayne Chen
2021-11-27 14:43 ` Lorenzo Bianconi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YaJEE0gKhZvtBs6n@lore-desk \
--to=lorenzo.bianconi@redhat.com \
--cc=deren.wu@mediatek.com \
--cc=evelyn.tsai@mediatek.com \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=nbd@nbd.name \
--cc=ryder.lee@mediatek.com \
--cc=shayne.chen@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox