From: Lorenzo Bianconi <lorenzo@kernel.org>
To: Felix Fietkau <nbd@nbd.name>
Cc: linux-wireless@vger.kernel.org, lorenzo.bianconi@redhat.com
Subject: Re: [PATCH] mt76: mt7663: disable 4addr capability
Date: Fri, 3 Dec 2021 11:07:15 +0100 [thread overview]
Message-ID: <YansU5YYPpv7+9d4@lore-desk> (raw)
In-Reply-To: <59de5a7b-8933-03c7-7ce5-fe58279c7457@nbd.name>
[-- Attachment #1: Type: text/plain, Size: 1052 bytes --]
>
> On 2021-12-02 20:35, Lorenzo Bianconi wrote:
> > 4addr is not supported by the driver/firmware yet
> >
> > Signed-off-by: Lorenzo Bianconi <lorenzo@kernel.org>
> > ---
> > drivers/net/wireless/mediatek/mt76/mt7615/init.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/net/wireless/mediatek/mt76/mt7615/init.c b/drivers/net/wireless/mediatek/mt76/mt7615/init.c
> > index 47f23ac905a3..52182ab6d240 100644
> > --- a/drivers/net/wireless/mediatek/mt76/mt7615/init.c
> > +++ b/drivers/net/wireless/mediatek/mt76/mt7615/init.c
> > @@ -378,6 +378,7 @@ mt7615_init_wiphy(struct ieee80211_hw *hw)
> > if (is_mt7663(&phy->dev->mt76)) {
> > wiphy->iface_combinations = if_comb;
> > wiphy->n_iface_combinations = ARRAY_SIZE(if_comb);
> > + wiphy->flags &= ~WIPHY_FLAG_4ADDR_STATION;
> Shouldn't this be done for the offload firmware only?
>
> - Felix
ack, right, I did not think about this combination. I tested with non-offload
fw and it works. I will post v2 to fix it.
Regards,
Lorenzo
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
prev parent reply other threads:[~2021-12-03 10:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-02 19:35 [PATCH] mt76: mt7663: disable 4addr capability Lorenzo Bianconi
2021-12-03 8:32 ` Felix Fietkau
2021-12-03 10:07 ` Lorenzo Bianconi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YansU5YYPpv7+9d4@lore-desk \
--to=lorenzo@kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=lorenzo.bianconi@redhat.com \
--cc=nbd@nbd.name \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).