From: Lorenzo Bianconi <lorenzo@kernel.org>
To: Kalle Valo <kvalo@kernel.org>
Cc: nbd@nbd.name, lorenzo.bianconi@redhat.com,
linux-wireless@vger.kernel.org, deren.wu@mediatek.com,
sean.wang@mediatek.com, sven@narfation.org
Subject: Re: [PATCH wireless-drivers] mt76: mt7921: fix a possible race enabling/disabling runtime-pm
Date: Tue, 21 Dec 2021 16:10:49 +0100 [thread overview]
Message-ID: <YcHueZZ01sMuG0Cz@lore-desk> (raw)
In-Reply-To: <878rwe6loy.fsf@kernel.org>
[-- Attachment #1: Type: text/plain, Size: 979 bytes --]
> Lorenzo Bianconi <lorenzo@kernel.org> writes:
>
> > Fix a possible race enabling/disabling runtime-pm between
> > mt7921_pm_set() and mt7921_poll_rx() since mt7921_pm_wake_work()
> > always schedules rx-napi callback and it will trigger
> > mt7921_pm_power_save_work routine putting chip to in low-power state
> > during mt7921_pm_set processing.
> >
> > Suggested-by: Deren Wu <deren.wu@mediatek.com>
> > Tested-by: Deren Wu <deren.wu@mediatek.com>
> > Fixes: 1d8efc741df8 ("mt76: mt7921: introduce Runtime PM support")
> > Signed-off-by: Lorenzo Bianconi <lorenzo@kernel.org>
>
> We are in -rc6 already, so I would prefer to take this to
> wireless-drivers-next instead. Is that ok?
I think wireless-drivers-next is fine since the bug is not so critical.
Regards,
Lorenzo
>
> Felix, ack?
>
> --
> https://patchwork.kernel.org/project/linux-wireless/list/
>
> https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2021-12-21 15:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-21 13:57 [PATCH wireless-drivers] mt76: mt7921: fix a possible race enabling/disabling runtime-pm Lorenzo Bianconi
2021-12-21 15:07 ` Kalle Valo
2021-12-21 15:10 ` Lorenzo Bianconi [this message]
2021-12-22 17:54 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YcHueZZ01sMuG0Cz@lore-desk \
--to=lorenzo@kernel.org \
--cc=deren.wu@mediatek.com \
--cc=kvalo@kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=lorenzo.bianconi@redhat.com \
--cc=nbd@nbd.name \
--cc=sean.wang@mediatek.com \
--cc=sven@narfation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox