From: Lorenzo Bianconi <lorenzo.bianconi@redhat.com>
To: Felix Fietkau <nbd@nbd.name>
Cc: Lorenzo Bianconi <lorenzo@kernel.org>,
linux-wireless@vger.kernel.org, ryder.lee@mediatek.com,
sean.wang@mediatek.com
Subject: Re: [PATCH 2/5] mt76: connac: move common mac defs in mt76_connac_mac.h
Date: Mon, 17 Jan 2022 11:55:29 +0100 [thread overview]
Message-ID: <YeVLITuTeO2+0dnb@lore-desk> (raw)
In-Reply-To: <6ba09c09-9248-99b9-f16b-1a2421e16cac@nbd.name>
[-- Attachment #1: Type: text/plain, Size: 860 bytes --]
> On 2022-01-16 13:43, Lorenzo Bianconi wrote:
> > Move mac definitions shared between mt7921 and mt7915 in
> > mt76_connac_mac.h header.
> >
> > Signed-off-by: Lorenzo Bianconi <lorenzo@kernel.org>
> > ---
> > .../wireless/mediatek/mt76/mt76_connac_mac.h | 292 +++++++++++++++++
> I think this should probably be put in mt76_connac2_mac.h or something like
> that. The definitions are different for 7663/7615 (connac v1), and they will
> probably be different again for newer chipset generations.
>
> Maybe we should reorganize the code to make it clear which parts are connac2
> specific.
>
> - Felix
>
ack. According to irc discussion with Ryder and Sean, I marked this series as
'superseded' in patchwork.
I guess we can keep patch 1/5: "mt76: connac: move mt76_connac_lmac_mapping in
mt76-connac module".
Regards,
Lorenzo
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2022-01-17 10:55 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-16 12:43 [PATCH 0/5] move shared mac code in mt76_connac module Lorenzo Bianconi
2022-01-16 12:43 ` [PATCH 1/5] mt76: connac: move mt76_connac_lmac_mapping in mt76-connac module Lorenzo Bianconi
2022-01-16 12:43 ` [PATCH 2/5] mt76: connac: move common mac defs in mt76_connac_mac.h Lorenzo Bianconi
2022-01-17 9:42 ` Felix Fietkau
2022-01-17 10:55 ` Lorenzo Bianconi [this message]
2022-01-16 12:43 ` [PATCH 3/5] mt76: connac: move mt76_connac_reverse_frag0_hdr_trans in common module Lorenzo Bianconi
2022-01-16 12:43 ` [PATCH 4/5] mt76: connac: move he radiotap parsing in connac module Lorenzo Bianconi
2022-01-16 17:55 ` Ryder Lee
2022-01-16 20:58 ` Lorenzo Bianconi
2022-01-16 12:43 ` [PATCH 5/5] mt76: connac: move mt76_connac_mac_write_txwi " Lorenzo Bianconi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YeVLITuTeO2+0dnb@lore-desk \
--to=lorenzo.bianconi@redhat.com \
--cc=linux-wireless@vger.kernel.org \
--cc=lorenzo@kernel.org \
--cc=nbd@nbd.name \
--cc=ryder.lee@mediatek.com \
--cc=sean.wang@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).