From: Greg KH <gregkh@linuxfoundation.org>
To: Solomon Tan <solomonbstoner@protonmail.ch>
Cc: linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org, rdunlap@infradead.org,
miriam.rachel.korenblit@intel.com, johannes.berg@intel.com,
pabeni@redhat.com, kuba@kernel.org, davem@davemloft.net,
kvalo@kernel.org, luciano.coelho@intel.com
Subject: Re: [PATCH 0/3] iwlwifi: Address whitespace coding style errors
Date: Tue, 19 Apr 2022 08:02:47 +0200 [thread overview]
Message-ID: <Yl5QhzP75YB0K470@kroah.com> (raw)
In-Reply-To: <20220419011340.14954-1-solomonbstoner@protonmail.ch>
On Tue, Apr 19, 2022 at 01:14:20AM +0000, Solomon Tan wrote:
> This series of three patches addresses the whitespace coding style
> errors marked by checkpatch.pl as an "ERROR". In order of sequence,
> the following edits are made:
> 1. Removal of prohibited spaces
> 2. Addition of required space
> 3. Replacement of space with tabs as code indent.
>
> Signed-off-by: Solomon Tan <solomonbstoner@protonmail.ch>
>
No need to ever sign off on a 0/X email.
Also, not all of these were threaded properly, and are you sure that
coding style "fixes" like these are welcome for this part of the kernel?
I recommend starting out in drivers/staging/ first to learn the process
before going anywhere else.
And finally, why cc: me at all? I am not a wireless developer :)
good luck!
greg k-h
prev parent reply other threads:[~2022-04-19 6:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-19 1:14 [PATCH 0/3] iwlwifi: Address whitespace coding style errors Solomon Tan
2022-04-19 1:14 ` [PATCH 1/3] iwlwifi: Remove prohibited spaces Solomon Tan
2022-04-19 1:15 ` [PATCH 2/3] iwlwifi: Add required space before open '(' Solomon Tan
2022-04-19 6:02 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yl5QhzP75YB0K470@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=davem@davemloft.net \
--cc=johannes.berg@intel.com \
--cc=kuba@kernel.org \
--cc=kvalo@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=luciano.coelho@intel.com \
--cc=miriam.rachel.korenblit@intel.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=rdunlap@infradead.org \
--cc=solomonbstoner@protonmail.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).