Re: [PATCH 3/4] mt76: mt7915: reject duplicated twt flows

Felix Fietkau
2022-05-05T12:26:41Z

On 05.05.22 14:22, Lorenzo Bianconi wrote:
>> Reject twt flows with the same parameters to prevent some potential issues
>> causing by duplicated establishment.
>>
>> Reviewed-by: Ryder Lee <ryder.lee@mediatek.com>
>> Reviewed-by: Shayne Chen <shayne.chen@mediatek.com>
>> Signed-off-by: Peter Chiu <chui-hao.chiu@mediatek.com>
>> ---
>> .../net/wireless/mediatek/mt76/mt7915/mac.c | 31 +++++++++++++++++++
>> 1 file changed, 31 insertions(+)
>>
>> diff --git a/drivers/net/wireless/mediatek/mt76/mt7915/mac.c b/drivers/net/wireless/mediatek/mt76/mt7915/mac.c
>> index 94a1871fbf43..ff60a3d2d26d 100644
>> --- a/drivers/net/wireless/mediatek/mt76/mt7915/mac.c
>> +++ b/drivers/net/wireless/mediatek/mt76/mt7915/mac.c
>> @@ -2601,6 +2601,34 @@ static int mt7915_mac_check_twt_req(struct ieee80211_twt_setup *twt)
>> return 0;
>> }
>>
>> +static inline bool
>> +mt7915_mac_twt_param_equal(struct mt7915_sta *msta,
>> + struct ieee80211_twt_params *twt_agrt)
>
> nit: please do not use inline in .c files.
I applied the patch already, so I folded in a fix for this.

- Felix