From: Dan Carpenter <dan.carpenter@oracle.com>
To: johannes.berg@intel.com
Cc: linux-wireless@vger.kernel.org
Subject: [bug report] wifi: nl80211: support MLO in auth/assoc
Date: Wed, 22 Jun 2022 10:03:14 +0300 [thread overview]
Message-ID: <YrK+sjPSFRxX4XAM@kili> (raw)
Hello Johannes Berg,
This is a semi-automatic email about new static checker warnings.
The patch d648c23024bd: "wifi: nl80211: support MLO in auth/assoc"
from May 31, 2022, leads to the following Smatch complaint:
net/wireless/mlme.c:328 cfg80211_mlme_assoc()
warn: variable dereferenced before check 'req->bss' (see line 324)
net/wireless/mlme.c
323
324 err = rdev_assoc(rdev, dev, req);
^^^
req->bss dereferenced inside the function call
325 if (!err) {
326 int link_id;
327
328 if (req->bss) {
^^^^^^^^
Check for NULL is too late
329 cfg80211_ref_bss(&rdev->wiphy, req->bss);
330 cfg80211_hold_bss(bss_from_pub(req->bss));
regards,
dan carpenter
next reply other threads:[~2022-06-22 7:03 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-22 7:03 Dan Carpenter [this message]
2022-06-22 8:11 ` [bug report] wifi: nl80211: support MLO in auth/assoc Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YrK+sjPSFRxX4XAM@kili \
--to=dan.carpenter@oracle.com \
--cc=johannes.berg@intel.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox