From: "Jason A. Donenfeld" <Jason@zx2c4.com>
To: Gregory Erwin <gregerwin256@gmail.com>
Cc: Miaoqing Pan <miaoqing@codeaurora.org>,
Rui Salvaterra <rsalvaterra@gmail.com>,
ath9k-devel <ath9k-devel@qca.qualcomm.com>,
linux-crypto@vger.kernel.org, linux-wireless@vger.kernel.org
Subject: Re: ath9k: hwrng blocks for several minutes when phy is un-associated
Date: Thu, 23 Jun 2022 14:16:32 +0200 [thread overview]
Message-ID: <YrRZoGBMBa3lFkwx@zx2c4.com> (raw)
In-Reply-To: <YrRZLPQHK0QbLTjr@zx2c4.com>
Or perhaps more simply:
diff --git a/drivers/net/wireless/ath/ath9k/rng.c b/drivers/net/wireless/ath/ath9k/rng.c
index cb5414265a9b..5b44cd918c2b 100644
--- a/drivers/net/wireless/ath/ath9k/rng.c
+++ b/drivers/net/wireless/ath/ath9k/rng.c
@@ -83,7 +83,8 @@ static int ath9k_rng_read(struct hwrng *rng, void *buf, size_t max, bool wait)
if (!wait || !max || likely(bytes_read) || fail_stats > 110)
break;
- msleep_interruptible(ath9k_rng_delay_get(++fail_stats));
+ if (msleep_interruptible(ath9k_rng_delay_get(++fail_stats)))
+ break;
}
if (wait && !bytes_read && max)
next prev parent reply other threads:[~2022-06-23 12:16 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-23 5:08 ath9k: hwrng blocks for several minutes when phy is un-associated Gregory Erwin
2022-06-23 12:14 ` Jason A. Donenfeld
2022-06-23 12:16 ` Jason A. Donenfeld [this message]
2022-06-23 23:36 ` Gregory Erwin
2022-06-23 23:47 ` Jason A. Donenfeld
2022-06-24 0:01 ` Jason A. Donenfeld
2022-06-24 0:50 ` Jason A. Donenfeld
2022-06-24 1:14 ` [PATCH] ath9k: rng: escape sleep loop when unregistering Jason A. Donenfeld
2022-06-24 5:25 ` Gregory Erwin
2022-06-24 19:12 ` Jason A. Donenfeld
2022-06-24 20:44 ` [PATCH v2] ath9k: sleep for less time when unregistering hwrng Jason A. Donenfeld
2022-06-25 0:13 ` Gregory Erwin
2022-06-25 0:40 ` Jason A. Donenfeld
2022-06-27 6:45 ` Herbert Xu
2022-06-27 9:29 ` [PATCH v3] " Jason A. Donenfeld
2022-06-27 10:49 ` [PATCH v4] " Jason A. Donenfeld
2022-06-27 11:37 ` [PATCH v5] " Jason A. Donenfeld
2022-06-27 12:07 ` [PATCH v6] " Jason A. Donenfeld
2022-06-27 12:18 ` Toke Høiland-Jørgensen
2022-06-28 1:39 ` Gregory Erwin
2022-06-28 10:46 ` Jason A. Donenfeld
2022-06-28 10:48 ` Jason A. Donenfeld
2022-06-28 10:51 ` Herbert Xu
2022-06-28 10:55 ` Jason A. Donenfeld
2022-06-28 12:05 ` Jason A. Donenfeld
2022-06-28 15:14 ` Jason A. Donenfeld
2022-06-28 1:53 ` Herbert Xu
2022-06-28 10:45 ` Toke Høiland-Jørgensen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YrRZoGBMBa3lFkwx@zx2c4.com \
--to=jason@zx2c4.com \
--cc=ath9k-devel@qca.qualcomm.com \
--cc=gregerwin256@gmail.com \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=miaoqing@codeaurora.org \
--cc=rsalvaterra@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).