From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4389DC433EF for ; Tue, 28 Jun 2022 15:14:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1346919AbiF1POv (ORCPT ); Tue, 28 Jun 2022 11:14:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48064 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1347435AbiF1POi (ORCPT ); Tue, 28 Jun 2022 11:14:38 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7493B2DD4B; Tue, 28 Jun 2022 08:14:37 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 2D3C6B81E39; Tue, 28 Jun 2022 15:14:36 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C8FA6C341CA; Tue, 28 Jun 2022 15:14:33 +0000 (UTC) Authentication-Results: smtp.kernel.org; dkim=pass (1024-bit key) header.d=zx2c4.com header.i=@zx2c4.com header.b="oLBJ0YWa" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=zx2c4.com; s=20210105; t=1656429272; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=CFZhZs8TzfzhOTKeWs1ZB/BO0Gr0GcTW1JXaKhw0cNw=; b=oLBJ0YWausVKY98yJMGJi14g8DZQmo795ECFKy0bXdC3gn8kE7fPyn2iZBLY5T8kXFAtOQ TfSMcFphCQX1ayLkldM2Hn5jja6e/tV69p70/MKVvjR0vmyB/QWVDzaZiF6OIA7RPKKw8K ehIu96WEX6EQY/m5z+GtZhmKI/ZqseA= Received: by mail.zx2c4.com (ZX2C4 Mail Server) with ESMTPSA id 5481adc8 (TLSv1.3:AEAD-AES256-GCM-SHA384:256:NO); Tue, 28 Jun 2022 15:14:31 +0000 (UTC) Date: Tue, 28 Jun 2022 17:14:27 +0200 From: "Jason A. Donenfeld" To: Herbert Xu Cc: Gregory Erwin , Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgensen?= , linux-wireless , LKML , Kalle Valo , Rui Salvaterra , stable Subject: Re: [PATCH v6] ath9k: sleep for less time when unregistering hwrng Message-ID: References: <20220627113749.564132-1-Jason@zx2c4.com> <20220627120735.611821-1-Jason@zx2c4.com> <87y1xib8pv.fsf@toke.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Hi Herbert, On Tue, Jun 28, 2022 at 02:05:34PM +0200, Jason A. Donenfeld wrote: > Hi again, > > On Tue, Jun 28, 2022 at 12:55:57PM +0200, Jason A. Donenfeld wrote: > > > Oh wait you're checking kthread_should_stop before the schedule > > > call instead of afterwards, that would do it. > > > > Oh, that's a really good observation, thank you! > > Wait, no. I already am kthread_should_stop() it afterwards. That > "continue" goes to the top of the loop, which checks it in the while() > statement. So something else is amiss. I guess I'll investigate. I worked out a solution for the "larger problem" now. It's a bit involved, but not too bad. I'll post a patch shortly. Jason