From: Simon Horman <simon.horman@corigine.com>
To: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Cc: Simon Kelley <simon@thekelleys.org.uk>,
Kalle Valo <kvalo@kernel.org>,
Dominik Brodowski <linux@dominikbrodowski.net>,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org,
linux-wireless@vger.kernel.org
Subject: Re: [PATCH wireless] atmel: Fix an error handling path in atmel_probe()
Date: Thu, 25 May 2023 11:22:02 +0200 [thread overview]
Message-ID: <ZG8oulcaldoFLOPl@corigine.com> (raw)
In-Reply-To: <1e65f174607a83348034197fa7d603bab10ba4a9.1684569156.git.christophe.jaillet@wanadoo.fr>
On Sat, May 20, 2023 at 09:53:14AM +0200, Christophe JAILLET wrote:
> Should atmel_config() fail, some resources need to be released as already
> done in the remove function.
>
> While at it, remove a useless and erroneous comment. The probe is
> atmel_probe(), not atmel_attach().
>
> Fixes: 15b99ac17295 ("[PATCH] pcmcia: add return value to _config() functions")
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Reviewed-by: Simon Horman <simon.horman@corigine.com>
next prev parent reply other threads:[~2023-05-25 9:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-20 7:53 [PATCH wireless] atmel: Fix an error handling path in atmel_probe() Christophe JAILLET
2023-05-25 9:22 ` Simon Horman [this message]
2023-05-25 16:16 ` [wireless] wifi: " Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZG8oulcaldoFLOPl@corigine.com \
--to=simon.horman@corigine.com \
--cc=christophe.jaillet@wanadoo.fr \
--cc=kernel-janitors@vger.kernel.org \
--cc=kvalo@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linux@dominikbrodowski.net \
--cc=simon@thekelleys.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).