From: Simon Horman <simon.horman@corigine.com>
To: Lorenzo Bianconi <lorenzo@kernel.org>
Cc: nbd@nbd.name, lorenzo.bianconi@redhat.com,
linux-wireless@vger.kernel.org
Subject: Re: [PATCH] wifi: mt76: mt7996: fix endianness warning in mt7996_mac_write_txwi
Date: Mon, 22 May 2023 14:22:18 +0200 [thread overview]
Message-ID: <ZGteemw+FvK0Kio6@corigine.com> (raw)
In-Reply-To: <9509f4bc32d9321f3419a3c0029a01b426f13fd8.1684746447.git.lorenzo@kernel.org>
On Mon, May 22, 2023 at 11:09:01AM +0200, Lorenzo Bianconi wrote:
> Fix the following endianness warning in mt7996_mac_write_txwi routine:
FWIIW, I think this fixes a bug on big endian hosts.
Which might be a better description.
But I don't feel strongly about this.
>
> drivers/net/wireless/mediatek/mt76/mt7996/mac.c:1091:25: warning: invalid assignment: |=
> drivers/net/wireless/mediatek/mt76/mt7996/mac.c:1091:25: left side has type restricted __le32
> drivers/net/wireless/mediatek/mt76/mt7996/mac.c:1091:25: right side has type unsigned long
>
> Fixes: 15ee62e73705 ("wifi: mt76: mt7996: enable BSS_CHANGED_BASIC_RATES support")
> Signed-off-by: Lorenzo Bianconi <lorenzo@kernel.org>
Reviewed-by: Simon Horman <simon.horman@corigine.com>
next prev parent reply other threads:[~2023-05-22 12:25 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-22 9:09 [PATCH] wifi: mt76: mt7996: fix endianness warning in mt7996_mac_write_txwi Lorenzo Bianconi
2023-05-22 12:22 ` Simon Horman [this message]
2023-05-24 9:46 ` Kalle Valo
2023-05-27 8:16 ` Kalle Valo
2023-05-27 9:26 ` Lorenzo Bianconi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZGteemw+FvK0Kio6@corigine.com \
--to=simon.horman@corigine.com \
--cc=linux-wireless@vger.kernel.org \
--cc=lorenzo.bianconi@redhat.com \
--cc=lorenzo@kernel.org \
--cc=nbd@nbd.name \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).