From: Lorenzo Bianconi <lorenzo@kernel.org>
To: Kalle Valo <kvalo@kernel.org>
Cc: nbd@nbd.name, lorenzo.bianconi@redhat.com,
linux-wireless@vger.kernel.org
Subject: Re: [PATCH] wifi: mt76: mt7996: fix endianness warning in mt7996_mac_write_txwi
Date: Sat, 27 May 2023 11:26:20 +0200 [thread overview]
Message-ID: <ZHHMvCLUmAXOc6wb@lore-desk> (raw)
In-Reply-To: <168517541096.19767.17568326076832648919.kvalo@kernel.org>
[-- Attachment #1: Type: text/plain, Size: 1972 bytes --]
> Lorenzo Bianconi <lorenzo@kernel.org> wrote:
>
> > Fix the following endianness warning in mt7996_mac_write_txwi routine:
> >
> > drivers/net/wireless/mediatek/mt76/mt7996/mac.c:1091:25: warning: invalid assignment: |=
> > drivers/net/wireless/mediatek/mt76/mt7996/mac.c:1091:25: left side has type restricted __le32
> > drivers/net/wireless/mediatek/mt76/mt7996/mac.c:1091:25: right side has type unsigned long
> >
> > Fixes: 15ee62e73705 ("wifi: mt76: mt7996: enable BSS_CHANGED_BASIC_RATES support")
> > Signed-off-by: Lorenzo Bianconi <lorenzo@kernel.org>
> > Reviewed-by: Simon Horman <simon.horman@corigine.com>
>
> Failed to apply, please rebase over wireless tree.
>
> error: sha1 information is lacking or useless (drivers/net/wireless/mediatek/mt76/mt7996/mac.c).
> error: could not build fake ancestor
> hint: Use 'git am --show-current-patch=diff' to see the failed patch
> Applying: wifi: mt76: mt7996: fix endianness warning in mt7996_mac_write_txwi
> Patch failed at 0001 wifi: mt76: mt7996: fix endianness warning in mt7996_mac_write_txwi
>
> Patch set to Changes Requested.
Hi Kalle,
my bad, it seems there is already a fix for this issue:
commit cdc26ee89bddb9b6b2ae026a46d97855d5ba6694
Author: Ryder Lee <ryder.lee@mediatek.com>
Date: Mon Apr 24 05:39:05 2023 +0800
wifi: mt76: mt7996: fix endianness of MT_TXD6_TX_RATE
To avoid sparse warning:
sparse: warning: invalid assignment: |=
sparse: left side has type restricted __le32
sparse: right side has type unsigned lon
Fixes: 15ee62e73705 ("wifi: mt76: mt7996: enable BSS_CHANGED_BASIC_RATES support")
we can drop this patch. Sorry for the noise.
Regards,
Lorenzo
>
> --
> https://patchwork.kernel.org/project/linux-wireless/patch/9509f4bc32d9321f3419a3c0029a01b426f13fd8.1684746447.git.lorenzo@kernel.org/
>
> https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
prev parent reply other threads:[~2023-05-27 9:26 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-22 9:09 [PATCH] wifi: mt76: mt7996: fix endianness warning in mt7996_mac_write_txwi Lorenzo Bianconi
2023-05-22 12:22 ` Simon Horman
2023-05-24 9:46 ` Kalle Valo
2023-05-27 8:16 ` Kalle Valo
2023-05-27 9:26 ` Lorenzo Bianconi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZHHMvCLUmAXOc6wb@lore-desk \
--to=lorenzo@kernel.org \
--cc=kvalo@kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=lorenzo.bianconi@redhat.com \
--cc=nbd@nbd.name \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).