From: Nam Cao <namcaov@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>
Cc: gregkh@linuxfoundation.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org,
syzbot+cf71097ffb6755df8251@syzkaller.appspotmail.com,
stable@vger.kernel.org
Subject: Re: [PATCH v2] staging: r8712: Fix memory leak in _r8712_init_xmit_priv()
Date: Wed, 19 Jul 2023 08:55:53 +0200 [thread overview]
Message-ID: <ZLeI+b3oXP3hstdg@nam-dell> (raw)
In-Reply-To: <20230714175417.18578-1-Larry.Finger@lwfinger.net>
On Fri, Jul 14, 2023 at 12:54:17PM -0500, Larry Finger wrote:
> In the above mentioned routine, memory is allocated in several places.
> If the first succeeds and a later one fails, the routine will leak memory.
> This patch fixes commit 2865d42c78a9 ("staging: r8712u: Add the new driver
> to the mainline kernel"). A potential memory leak in
> r8712_xmit_resource_alloc() is also addressed.
>
> Fixes: 2865d42c78a9 ("staging: r8712u: Add the new driver to the mainline kernel")
> Reported-by: syzbot+cf71097ffb6755df8251@syzkaller.appspotmail.com
> Closes: https://syzkaller.appspot.com/x/log.txt?x=11ac3fa0a80000
> Cc: stable@vger.kernel.org
> Cc: Nam Cao <namcaov@gmail.com>
> Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
I am not qualified to make comments on the code style, but it looks functionally
correct to me. So:
Reviewed-by: Nam Cao <namcaov@gmail.com>
Best regards,
Nam
prev parent reply other threads:[~2023-07-19 6:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-14 17:54 [PATCH v2] staging: r8712: Fix memory leak in _r8712_init_xmit_priv() Larry Finger
2023-07-19 6:55 ` Nam Cao [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZLeI+b3oXP3hstdg@nam-dell \
--to=namcaov@gmail.com \
--cc=Larry.Finger@lwfinger.net \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=linux-wireless@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=syzbot+cf71097ffb6755df8251@syzkaller.appspotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).