From: Brian Norris <briannorris@chromium.org>
To: Dmitry Antipov <dmantipov@yandex.ru>
Cc: Kalle Valo <kvalo@kernel.org>, linux-wireless@vger.kernel.org
Subject: Re: [PATCH] wifi: mwifiex: cleanup struct mwifiex_sdio_mpa_rx
Date: Fri, 25 Aug 2023 16:48:37 -0700 [thread overview]
Message-ID: <ZOk91ahez659Wu/t@google.com> (raw)
In-Reply-To: <20230821115254.167552-1-dmantipov@yandex.ru>
On Mon, Aug 21, 2023 at 02:52:50PM +0300, Dmitry Antipov wrote:
> Drop filled with NULL pointers but otherwise unused 'skb_arr'
> array of 'struct mwifiex_sdio_mpa_rx', adjust related code.
>
> Fixes: 960d6d08e395 ("mwifiex: delay skb allocation for RX until cmd53 over")
This is not the appropriate Fixes line. These fields continued to be
used afterward, so it would be actively harmful to tell people (or bots)
to backport this patch that far.
I'm not even going to tell you what the last commit that used it was,
because that would still just be nonsense. It's better to have no Fixes
line than to conjure up a garbage one, especially for something for
trivial.
> Signed-off-by: Dmitry Antipov <dmantipov@yandex.ru>
The contents look good though:
Acked-by: Brian Norris <briannorris@chromium.org>
next prev parent reply other threads:[~2023-08-25 23:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-21 11:52 [PATCH] wifi: mwifiex: cleanup struct mwifiex_sdio_mpa_rx Dmitry Antipov
2023-08-25 23:48 ` Brian Norris [this message]
2023-09-21 6:29 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZOk91ahez659Wu/t@google.com \
--to=briannorris@chromium.org \
--cc=dmantipov@yandex.ru \
--cc=kvalo@kernel.org \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).