From: Brian Norris <briannorris@chromium.org>
To: Dmitry Antipov <dmantipov@yandex.ru>
Cc: Kalle Valo <kvalo@kernel.org>,
linux-wireless@vger.kernel.org, lvc-project@linuxtesting.org
Subject: Re: [PATCH 1/2] wifi: mwifiex: simplify PCIE write operations
Date: Wed, 20 Sep 2023 16:31:38 -0700 [thread overview]
Message-ID: <ZQuA2u9l1mCRVYdz@google.com> (raw)
In-Reply-To: <20230919132804.73340-1-dmantipov@yandex.ru>
On Tue, Sep 19, 2023 at 04:27:59PM +0300, Dmitry Antipov wrote:
> Since 'mwifiex_write_reg()' just issues void 'iowrite32()',
> convert the former to 'void' and simplify all related users
> (with the only exception of 'read_poll_timeout()' which
> explicitly requires a non-void function argument).
>
> Found by Linux Verification Center (linuxtesting.org) with SVACE.
>
> Signed-off-by: Dmitry Antipov <dmantipov@yandex.ru>
> ---
> drivers/net/wireless/marvell/mwifiex/pcie.c | 290 +++++---------------
> 1 file changed, 66 insertions(+), 224 deletions(-)
Acked-by: Brian Norris <briannorris@chromium.org>
> diff --git a/drivers/net/wireless/marvell/mwifiex/pcie.c b/drivers/net/wireless/marvell/mwifiex/pcie.c
> index 6697132ecc97..88f632b9dd93 100644
> --- a/drivers/net/wireless/marvell/mwifiex/pcie.c
> +++ b/drivers/net/wireless/marvell/mwifiex/pcie.c
...
> +/* Non-void wrapper needed for read_poll_timeout(). */
> +static inline int
> +mwifiex_write_reg_rpt(struct mwifiex_adapter *adapter, int reg, u32 data)
This is kind of a weird name, but I don't have better suggestions. Maybe
it helps dissuade people from using it outside its very specific context
(where you have to read the comment to understand what "rpt" means).
next prev parent reply other threads:[~2023-09-20 23:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-19 13:27 [PATCH 1/2] wifi: mwifiex: simplify PCIE write operations Dmitry Antipov
2023-09-19 13:28 ` [PATCH 2/2] wifi: mwifiex: followup PCIE and related cleanups Dmitry Antipov
2023-09-20 23:36 ` Brian Norris
2023-09-20 23:31 ` Brian Norris [this message]
2023-09-22 7:43 ` [PATCH 1/2] wifi: mwifiex: simplify PCIE write operations Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZQuA2u9l1mCRVYdz@google.com \
--to=briannorris@chromium.org \
--cc=dmantipov@yandex.ru \
--cc=kvalo@kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=lvc-project@linuxtesting.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).