From: Sunil V L <sunilvl@ventanamicro.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org,
Gregory Greenman <gregory.greenman@intel.com>,
Kalle Valo <kvalo@kernel.org>,
Palmer Dabbelt <palmer@rivosinc.com>,
Conor Dooley <conor.dooley@microchip.com>,
Andrew Jones <ajones@ventanamicro.com>,
kernel test robot <lkp@intel.com>
Subject: Re: [PATCH] wifi: iwlwifi: Fix warning by adding dependency on DMI
Date: Thu, 9 Nov 2023 20:41:24 +0530 [thread overview]
Message-ID: <ZUz2nLO28djDYZHJ@sunil-laptop> (raw)
In-Reply-To: <5a5203915a94a0299131d3e03d132c40bd98dee6.camel@sipsolutions.net>
On Thu, Nov 09, 2023 at 10:09:53AM +0100, Johannes Berg wrote:
> On Thu, 2023-11-09 at 11:10 +0530, Sunil V L wrote:
> > This driver currently assumes CONFIG_DMI is enabled along with ACPI.
> > This may not be true. Due to this, the kernel test bot reports new
> > warning like below for RISC-V allyesconfig builds.
> >
> > > > drivers/net/wireless/intel/iwlwifi/fw/acpi.c:1190:25:
> > warning: '%s' directive argument is null [-Wformat-overflow=]
> >
> > 1190 | "System vendor '%s' is not in the approved list, disabling PPAG.\n",
> >
> > Fix the warning by adding dependency on CONFIG_DMI.
> >
>
> Not sure that's the right fix - why not put checks in the code there?
>
> Is it just a build warning?
>
> maybe
>
> -dmi_get_system_info(DMI_SYS_VENDOR)
> +dmi_get_system_info(DMI_SYS_VENDOR) ?: "<unknown>"
>
Thanks!, Johannes. It is a build warning because of allyesconfig build.
Your suggestion works. I will send v2 with this solution.
Thanks,
Sunil
prev parent reply other threads:[~2023-11-09 15:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-09 5:40 [PATCH] wifi: iwlwifi: Fix warning by adding dependency on DMI Sunil V L
2023-11-09 9:09 ` Johannes Berg
2023-11-09 15:11 ` Sunil V L [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZUz2nLO28djDYZHJ@sunil-laptop \
--to=sunilvl@ventanamicro.com \
--cc=ajones@ventanamicro.com \
--cc=conor.dooley@microchip.com \
--cc=gregory.greenman@intel.com \
--cc=johannes@sipsolutions.net \
--cc=kvalo@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=lkp@intel.com \
--cc=palmer@rivosinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox