From: Lorenzo Bianconi <lorenzo@kernel.org>
To: Kalle Valo <kvalo@kernel.org>
Cc: linux-wireless@vger.kernel.org, lorenzo.bianconi@redhat.com,
nbd@nbd.name, sean.wang@mediatek.com, deren.wu@mediatek.com
Subject: Re: [PATCH wireless] wifi: mt76: mt7925: fix typo in mt7925_init_he_caps
Date: Mon, 13 Nov 2023 13:32:03 +0100 [thread overview]
Message-ID: <ZVIXQx4nb25pO0EP@lore-desk> (raw)
In-Reply-To: <87cywdvox0.fsf@kernel.org>
[-- Attachment #1: Type: text/plain, Size: 843 bytes --]
> Lorenzo Bianconi <lorenzo@kernel.org> writes:
>
> > Use iftype for interface type switch in mt7925_init_he_caps routine
> >
> > Fixes: c948b5da6bbe ("wifi: mt76: mt7925: add Mediatek Wi-Fi7 driver
> > for mt7925 chips")
> > Signed-off-by: Lorenzo Bianconi <lorenzo@kernel.org>
>
> What issue does this fix? In other words, what are the user visible
> symptoms?
Since we are using i (equal to 8 after the for loop above) instead of iftype
we are missing some HE capabilities exposed to userspace (we are hitting the
switch default branch). I agree this is something not so harmful and we can
apply this fix to Felix's tree instead, up to you.
Regards,
Lorenzo
>
> --
> https://patchwork.kernel.org/project/linux-wireless/list/
>
> https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2023-11-13 12:32 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-13 10:06 [PATCH wireless] wifi: mt76: mt7925: fix typo in mt7925_init_he_caps Lorenzo Bianconi
2023-11-13 12:05 ` Kalle Valo
2023-11-13 12:32 ` Lorenzo Bianconi [this message]
2023-11-13 12:39 ` Kalle Valo
2023-11-13 12:41 ` Lorenzo Bianconi
2023-11-14 10:04 ` Kalle Valo
2023-11-14 10:30 ` Lorenzo Bianconi
2023-11-22 15:57 ` [wireless] " Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZVIXQx4nb25pO0EP@lore-desk \
--to=lorenzo@kernel.org \
--cc=deren.wu@mediatek.com \
--cc=kvalo@kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=lorenzo.bianconi@redhat.com \
--cc=nbd@nbd.name \
--cc=sean.wang@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox