From: Brian Norris <briannorris@chromium.org>
To: David Lin <yu-hao.lin@nxp.com>
Cc: Francesco Dolcini <francesco@dolcini.it>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"kvalo@kernel.org" <kvalo@kernel.org>,
Pete Hsieh <tsung-hsien.hsieh@nxp.com>
Subject: Re: [EXT] Re: [PATCH v7 04/12] wifi: mwifiex: fixed missing WMM IE for assoc req.
Date: Wed, 13 Dec 2023 18:16:03 -0800 [thread overview]
Message-ID: <ZXplY3Gi6Fv19Y_t@google.com> (raw)
In-Reply-To: <PA4PR04MB963816B99845D943B4D061E2D181A@PA4PR04MB9638.eurprd04.prod.outlook.com>
On Fri, Dec 01, 2023 at 10:47:41PM +0000, David Lin wrote:
> > From: Francesco Dolcini <francesco@dolcini.it>
> > Sent: Friday, December 1, 2023 6:19 PM
> > On Tue, Nov 28, 2023 at 04:31:07PM +0800, David Lin wrote:
> > > Remain on channel must be removed after authentication is done.
> > > Otherwise WMM setting for assoiation request will be removed.
> >
> > Same comment as patch 2, this seems a fixup of commit 1, you should fix
> > that patch, not add a followup fixup commit.
>
> So you think patch 1 to 4 should be merged as a single patch? In fact,
> patch 2 to 4 is issues reported by our QA for patch 1. If you insisted
> merge all of them, I can do this for patch v8.
In case you didn't get a sufficient answer elsewhere: yes, probably? We
don't care to see:
patch 1: introduce feature
patch 2: fix bug in patch 1
patch 3: fix bug in patch 1 and 2
patch 4: ...
Just ... actually fix patch 1, and send 1 patch. (Or more, if you have
several logical changes. Be sure to read [1].)
In case you're used to GitHub: we don't work like GitHub, where people
tend to stack a bunch of incremental changes during review, and then the
changes get squashed together before committing. We expect each patch to
be a good commit, and that it will get committed as-is.
If we're interested in the history and evolution of your changes, we can
look at the mailing list archives.
Brian
[1] https://docs.kernel.org/process/submitting-patches.html#separate-your-changes
next prev parent reply other threads:[~2023-12-14 2:16 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-28 8:31 [PATCH v7 00/12] wifi: mwifiex: added code to support host mlme David Lin
2023-11-28 8:31 ` [PATCH v7 01/12] " David Lin
2023-11-28 22:51 ` kernel test robot
2023-11-28 8:31 ` [PATCH v7 02/12] wifi: mwifiex: fixed group rekey issue for WPA3 David Lin
2023-12-01 10:15 ` Francesco Dolcini
2023-12-01 15:05 ` Jeff Johnson
2023-12-01 23:18 ` [EXT] " David Lin
2023-12-01 22:41 ` David Lin
2023-11-28 8:31 ` [PATCH v7 03/12] wifi: mwifiex: fixed reassocation " David Lin
2023-12-01 10:17 ` Francesco Dolcini
2023-12-01 22:44 ` [EXT] " David Lin
2023-11-28 8:31 ` [PATCH v7 04/12] wifi: mwifiex: fixed missing WMM IE for assoc req David Lin
2023-12-01 10:18 ` Francesco Dolcini
2023-12-01 22:47 ` [EXT] " David Lin
2023-12-14 2:16 ` Brian Norris [this message]
2023-12-14 2:20 ` David Lin
2023-11-28 8:31 ` [PATCH v7 05/12] wifi: mwifiex: supported host mlme for AP mode David Lin
2023-11-28 8:31 ` [PATCH v7 06/12] wifi: mwifiex: added mac address for AP config David Lin
2023-12-01 10:31 ` Francesco Dolcini
2023-12-01 22:50 ` [EXT] " David Lin
2023-12-03 16:13 ` Jeff Johnson
2023-12-04 1:56 ` David Lin
2023-11-28 8:31 ` [PATCH v7 07/12] wifi: mwifiex: fixed TLV error for station add cmd David Lin
2023-12-01 10:36 ` Francesco Dolcini
2023-12-01 22:52 ` [EXT] " David Lin
2023-11-28 8:31 ` [PATCH v7 08/12] wifi: mwifiex: fixed the way to handle assoc timeout David Lin
2023-12-01 10:37 ` Francesco Dolcini
2023-11-28 8:31 ` [PATCH v7 09/12] wifi: mwifiex: fixed the way to handle link lost David Lin
2023-12-01 10:38 ` Francesco Dolcini
2023-11-28 8:31 ` [PATCH v7 10/12] wifi: mwifiex: fixed AP issue without host mlme David Lin
2023-12-01 10:39 ` Francesco Dolcini
2023-11-28 8:31 ` [PATCH v7 11/12] wifi: mwifiex: misc modifications for review comments David Lin
2023-12-01 10:40 ` Francesco Dolcini
2023-11-28 8:31 ` [PATCH v7 12/12] wifi: mwifiex: fixed compile and coding errors David Lin
2023-12-01 10:43 ` Francesco Dolcini
2023-12-01 11:49 ` [PATCH v7 00/12] wifi: mwifiex: added code to support host mlme Francesco Dolcini
2023-12-01 12:25 ` Kalle Valo
2023-12-01 23:12 ` [EXT] " David Lin
2023-12-01 23:05 ` David Lin
2023-12-05 19:46 ` Francesco Dolcini
2023-12-06 1:49 ` David Lin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZXplY3Gi6Fv19Y_t@google.com \
--to=briannorris@chromium.org \
--cc=francesco@dolcini.it \
--cc=kvalo@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=tsung-hsien.hsieh@nxp.com \
--cc=yu-hao.lin@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).