From: Breno Leitao <leitao@debian.org>
To: michael.nemanov@ti.com
Cc: Kalle Valo <kvalo@kernel.org>,
Johannes Berg <johannes.berg@intel.com>,
Justin Stitt <justinstitt@google.com>,
Kees Cook <keescook@chromium.org>,
linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org,
Sabeeh Khan <sabeeh-khan@ti.com>
Subject: Re: [PATCH 07/17] Add boot.c, boot.h
Date: Wed, 22 May 2024 01:54:24 -0700 [thread overview]
Message-ID: <Zk2ywFQQ2SuXvPiE@gmail.com> (raw)
In-Reply-To: <20240521171841.884576-8-michael.nemanov@ti.com>
Hello Michael,
On Tue, May 21, 2024 at 08:18:31PM +0300, michael.nemanov@ti.com wrote:
> From: Michael Nemanov <Michael.Nemanov@ti.com>
> +static u8 *fetch_container(struct cc33xx *cc, const char *container_name,
> + size_t *container_len)
> +{
> + u8 *container_data = NULL;
> + const struct firmware *container;
> + int ret;
> +
> + ret = request_firmware(&container, container_name, cc->dev);
> +
> + if (ret < 0) {
> + cc33xx_error("could not get container %s: (%d)",
> + container_name, ret);
> + return NULL;
> + }
> +
> + if (container->size % 4) {
> + cc33xx_error("container size is not word-aligned: %zu",
> + container->size);
> + goto out;
> + }
> +
> + *container_len = container->size;
> + container_data = vmalloc(container->size);
I got the following error when compiling it:
drivers/net/wireless/ti/cc33xx/boot.c: In function ‘fetch_container’:
drivers/net/wireless/ti/cc33xx/boot.c:76:26: error: implicit declaration of function ‘vmalloc’; did you mean ‘kmalloc’? [-Werror=implicit-function-declaration]
76 | container_data = vmalloc(container->size);
| ^~~~~~~
| kmalloc
drivers/net/wireless/ti/cc33xx/boot.c:76:24: warning: assignment to ‘u8 *’ {aka ‘unsigned char *’} from ‘int’ makes pointer from integer without a cast [-Wint-conversion]
76 | container_data = vmalloc(container->size);
next prev parent reply other threads:[~2024-05-22 8:54 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-21 17:18 [PATCH 00/17] wifi: cc33xx: Add driver for new TI CC33xx wireless device family michael.nemanov
2024-05-21 17:18 ` [PATCH 01/17] Add cc33xx.h, cc33xx_i.h michael.nemanov
2024-05-22 9:38 ` Krzysztof Kozlowski
2024-05-22 15:44 ` Nemanov, Michael
2024-08-06 16:56 ` Nemanov, Michael
2024-05-21 17:18 ` [PATCH 02/17] Add debug.h michael.nemanov
2024-05-21 17:18 ` [PATCH 03/17] Add sdio.c, io.c, io.h michael.nemanov
2024-05-21 17:18 ` [PATCH 04/17] Add cmd.c, cmd.h michael.nemanov
2024-05-21 17:18 ` [PATCH 05/17] Add acx.c, acx.h michael.nemanov
2024-05-21 17:18 ` [PATCH 06/17] Add event.c, event.h michael.nemanov
2024-05-21 17:18 ` [PATCH 07/17] Add boot.c, boot.h michael.nemanov
2024-05-22 8:54 ` Breno Leitao [this message]
2024-05-22 11:12 ` Krzysztof Kozlowski
2024-05-22 15:15 ` [EXTERNAL] " Nemanov, Michael
2024-05-21 17:18 ` [PATCH 08/17] Add main.c michael.nemanov
2024-05-22 8:52 ` Breno Leitao
2024-05-22 9:46 ` Krzysztof Kozlowski
2024-05-30 11:54 ` Nemanov, Michael
2024-05-30 14:37 ` Kalle Valo
2024-05-31 7:35 ` Krzysztof Kozlowski
2024-05-31 13:50 ` Nemanov, Michael
2024-06-05 9:55 ` Nemanov, Michael
2024-06-05 10:04 ` Krzysztof Kozlowski
2024-06-05 11:13 ` Kalle Valo
2024-05-21 17:18 ` [PATCH 09/17] Add rx.c, rx.h michael.nemanov
2024-05-22 8:55 ` Breno Leitao
2024-05-26 6:03 ` Nemanov, Michael
2024-05-21 17:18 ` [PATCH 10/17] Add tx.c, tx.h michael.nemanov
2024-05-21 17:18 ` [PATCH 11/17] Add init.c, init.h michael.nemanov
2024-05-21 17:18 ` [PATCH 12/17] Add scan.c, scan.h michael.nemanov
2024-05-21 17:18 ` [PATCH 13/17] Add conf.h michael.nemanov
2024-05-22 9:48 ` Krzysztof Kozlowski
2024-05-23 7:08 ` Kalle Valo
2024-05-23 7:13 ` Krzysztof Kozlowski
2024-05-23 7:18 ` Kalle Valo
2024-05-24 7:48 ` Nemanov, Michael
2024-05-21 17:18 ` [PATCH 14/17] Add ps.c, ps.h michael.nemanov
2024-05-21 17:18 ` [PATCH 15/17] Add testmode.c, testmode.h michael.nemanov
2024-05-21 17:18 ` [PATCH 16/17] Add Kconfig, Makefile and integrate into wireless/ti folder michael.nemanov
2024-05-21 17:18 ` [PATCH 17/17] Add ti,cc33xx.yaml michael.nemanov
2024-05-22 9:35 ` Krzysztof Kozlowski
2024-05-26 6:35 ` Nemanov, Michael
2024-05-23 7:15 ` [PATCH 00/17] wifi: cc33xx: Add driver for new TI CC33xx wireless device family Kalle Valo
2024-05-24 7:48 ` Nemanov, Michael
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zk2ywFQQ2SuXvPiE@gmail.com \
--to=leitao@debian.org \
--cc=johannes.berg@intel.com \
--cc=justinstitt@google.com \
--cc=keescook@chromium.org \
--cc=kvalo@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=michael.nemanov@ti.com \
--cc=sabeeh-khan@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).