linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Sascha Hauer <s.hauer@pengutronix.de>
To: Francesco Dolcini <francesco@dolcini.it>
Cc: Brian Norris <briannorris@chromium.org>,
	Kalle Valo <kvalo@kernel.org>,
	linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] wifi: mwifiex: add support for WPA-PSK-SHA256
Date: Wed, 17 Jul 2024 08:12:16 +0200	[thread overview]
Message-ID: <ZpdgwCyoYPAFLBJI@pengutronix.de> (raw)
In-Reply-To: <20240716195731.GB85916@francesco-nb>

Hi Francesco,

On Tue, Jul 16, 2024 at 09:57:31PM +0200, Francesco Dolcini wrote:
> Hello Sascha,
> 
> On Tue, Jul 16, 2024 at 01:33:28PM +0200, Sascha Hauer wrote:
> > This adds support for the WPA-PSK AKM suite with SHA256 as hashing
> > method (WPA-PSK-SHA256). Tested with a wpa_supplicant provided AP
> > using key_mgmt=WPA-PSK-SHA256.
> 
> Do you have any more details on which chip/firmware you tested?
> The change looks good, I am just wondering if there are reasons this
> might create issue on some specific chip/firmware combination.

I have a IW416 with firmware 16.92.21.p119. The change itself is derived
from the downstream driver. The downstream driver also sets the
KEY_MGMT_PSK_SHA256 bit unconditionally for all chip/firmware
combinations so I think this change should be ok.

Sascha

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

  reply	other threads:[~2024-07-17  6:12 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-16 11:33 [PATCH 0/2] mwifiex: add support for WPA-PSK-SHA256 Sascha Hauer
2024-07-16 11:33 ` [PATCH 1/2] wifi: mwifiex: simplify WPA flags setting Sascha Hauer
2024-07-16 19:48   ` Francesco Dolcini
2024-07-17  6:26     ` Sascha Hauer
2024-07-17  8:07       ` Francesco Dolcini
2024-07-17  8:34         ` Sascha Hauer
2024-07-16 11:33 ` [PATCH 2/2] wifi: mwifiex: add support for WPA-PSK-SHA256 Sascha Hauer
2024-07-16 19:57   ` Francesco Dolcini
2024-07-17  6:12     ` Sascha Hauer [this message]
2024-07-17  8:10       ` Francesco Dolcini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZpdgwCyoYPAFLBJI@pengutronix.de \
    --to=s.hauer@pengutronix.de \
    --cc=briannorris@chromium.org \
    --cc=francesco@dolcini.it \
    --cc=kvalo@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).