From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f179.google.com (mail-pl1-f179.google.com [209.85.214.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7C489146581 for ; Thu, 18 Jul 2024 22:40:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.179 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1721342426; cv=none; b=URRCTE2cvyJKqfF6KZXIxISTENhJETxE163JB1NoXhOzSBa5M5gJ6dc0hCGNXZmusGAHlwkJIdbVpakTZVMLiiliyUIlQp/0cr8xLGZJruPcqdmfgbxIUtgJL/pmw7vgZRrwXl4dhKGLHFSJo6B/ZX+R/stedb3TQ4BuGsuDA50= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1721342426; c=relaxed/simple; bh=eO4kp5UnAFjHe0AUrdjmpzGkp19tTMi8cto7wpmuUo4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=OG8ugasmNFj/GDBedwJFQbWGfdnhfspl0GnQzulKBsmvt1kHEW2fmJOpqCj+PeZF+4tG/HXBwRrdD4h5jBlJvorg8Ja5Sb3U8iaXtFoK8zq0e7RXBv6pG1SXkuQtPGbEQF3b1fYmFUXJkw7z6zOibpc86FIbefJ2RAqYFp30238= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=AIISX/fv; arc=none smtp.client-ip=209.85.214.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="AIISX/fv" Received: by mail-pl1-f179.google.com with SMTP id d9443c01a7336-1fc4fcbb131so12732145ad.3 for ; Thu, 18 Jul 2024 15:40:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1721342425; x=1721947225; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=PRG+NPGSiSWOUHh6HQYRv8V/Xn8Q2Cj3365oPP+4wFQ=; b=AIISX/fvPYmotAlIDBwA9zKc8Pn7TVbSxl+UYLqh1nk2vWtkMcnycBo/yQXeIYNFtt 6AsDK+2lyHBTMzyBu5+4cW3PLYvBUPy3rxPKnbumnMrPFp3gj8lee7Q7quenYPvVIOhH QI+pNFy1VF3Hz8O1TthUYzQmk6RcMNnWDlOFQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1721342425; x=1721947225; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=PRG+NPGSiSWOUHh6HQYRv8V/Xn8Q2Cj3365oPP+4wFQ=; b=baE9/as/Z8i3uWUREjws1odtH0Bnj0rj55pf4trk7byvZgPUcTEgwIgnNixTe3CuD/ UhJckimetoEMHOpsTRvAjOPam4Iryingj9aCV+axvibIq5aYX1FI+NuYR3dFgEuMxq72 J2yr5hhEZNPL3heWvpGQeUb7wLZKc2YAjrhTUfUtGEO58iIjblmQr/pZrQlTAKnw5BRR FFAfaWrWYeTpAIo7H0k8XPnQ2rtnCfwdmw1zn92wfFKAXpJmqRB9lBiWn/RvifcSwSdq 74Jbun8xaE+0+NtCnXq36jcRXSRcGsXQ0gkfDMaIbHJQfZngShyelzUhc8UdmTf8XgpS l3mA== X-Forwarded-Encrypted: i=1; AJvYcCVx5EBCEEIv3GoI3OnSvaQ++QOG2HIO9XAano6kHYPFF/zbP3aVD0vE3JKdlpDlca6Ft7FWqIiLrwFdSmcE8Ok5zZ3Ifzb+pzIJLupe/Lo= X-Gm-Message-State: AOJu0Yw4UgTQ21fQ4MyQwwVOU/2fZXtC3We3xYYLE9sU/9O4Te4GJ8iE t/1BXcDlWfm2kwxN/n/HQj90ixagJwGjYNKluza60j6cro7Yo+xCPFC8/NwoVg== X-Google-Smtp-Source: AGHT+IHPPfOj5xqA6lG9mYFBLww0N5/Dr3B2IsBfaETqr5dvarjLSc3DnhpSh6aTqlJa4NnhTIS1XA== X-Received: by 2002:a17:902:d4c9:b0:1fa:2e45:bcb8 with SMTP id d9443c01a7336-1fc4e1540c8mr50924495ad.2.1721342424734; Thu, 18 Jul 2024 15:40:24 -0700 (PDT) Received: from localhost ([2620:15c:9d:2:35aa:f87d:7549:3938]) by smtp.gmail.com with UTF8SMTPSA id d9443c01a7336-1fd64b49c7asm912195ad.21.2024.07.18.15.40.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 18 Jul 2024 15:40:24 -0700 (PDT) Date: Thu, 18 Jul 2024 15:40:22 -0700 From: Brian Norris To: Sascha Hauer Cc: Francesco Dolcini , Kalle Valo , linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 1/2] wifi: mwifiex: simplify WPA flags setting Message-ID: References: <20240717-mwifiex-wpa-psk-sha256-v2-0-eb53d5082b62@pengutronix.de> <20240717-mwifiex-wpa-psk-sha256-v2-1-eb53d5082b62@pengutronix.de> Precedence: bulk X-Mailing-List: linux-wireless@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240717-mwifiex-wpa-psk-sha256-v2-1-eb53d5082b62@pengutronix.de> On Wed, Jul 17, 2024 at 10:30:07AM +0200, Sascha Hauer wrote: > The WPA flags setting only depends on the wpa_versions bitfield and not > on the AKM suite, so move it out of the switch/case to simplify the code > a bit. Also set bss_config->protocol to zero explicitly. This is done > only to make the code clearer, bss_config has been zero alloced by the > caller, so should be zero already. No functional change intended. > > Signed-off-by: Sascha Hauer > --- > drivers/net/wireless/marvell/mwifiex/uap_cmd.c | 28 ++++++++------------------ > 1 file changed, 8 insertions(+), 20 deletions(-) Acked-by: Brian Norris