* [PATCH v2] wifi: cfg80211: fix reporting failed MLO links status with cfg80211_connect_done
@ 2024-07-24 12:53 Veerendranath Jakkam
2024-07-24 13:40 ` Carlos Llamas
0 siblings, 1 reply; 2+ messages in thread
From: Veerendranath Jakkam @ 2024-07-24 12:53 UTC (permalink / raw)
To: johannes; +Cc: linux-wireless, quic_vjakkam
Individual MLO links connection status not copied to
EVENT_CONNECT_RESULT data while processing the connect response
information in cfg80211_connect_done(). Due to this failed links also
indicated with success status in EVENT_CONNECT_RESULT.
To fix this, copy the individual MLO links status to
EVENT_CONNECT_RESULT data.
Fixes: 53ad07e9823b ("wifi: cfg80211: support reporting failed links")
Signed-off-by: Veerendranath Jakkam <quic_vjakkam@quicinc.com>
---
v2:
- Add "Fixes:" tag in commit text.
---
net/wireless/sme.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/net/wireless/sme.c b/net/wireless/sme.c
index e419aa8c4a5a..d9d7bf8bb5c1 100644
--- a/net/wireless/sme.c
+++ b/net/wireless/sme.c
@@ -1045,6 +1045,7 @@ void cfg80211_connect_done(struct net_device *dev,
cfg80211_hold_bss(
bss_from_pub(params->links[link].bss));
ev->cr.links[link].bss = params->links[link].bss;
+ ev->cr.links[link].status = params->links[link].status;
if (params->links[link].addr) {
ev->cr.links[link].addr = next;
--
2.34.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2] wifi: cfg80211: fix reporting failed MLO links status with cfg80211_connect_done
2024-07-24 12:53 [PATCH v2] wifi: cfg80211: fix reporting failed MLO links status with cfg80211_connect_done Veerendranath Jakkam
@ 2024-07-24 13:40 ` Carlos Llamas
0 siblings, 0 replies; 2+ messages in thread
From: Carlos Llamas @ 2024-07-24 13:40 UTC (permalink / raw)
To: Veerendranath Jakkam; +Cc: johannes, linux-wireless
On Wed, Jul 24, 2024 at 06:23:27PM +0530, Veerendranath Jakkam wrote:
> Individual MLO links connection status not copied to
> EVENT_CONNECT_RESULT data while processing the connect response
> information in cfg80211_connect_done(). Due to this failed links also
> indicated with success status in EVENT_CONNECT_RESULT.
>
> To fix this, copy the individual MLO links status to
> EVENT_CONNECT_RESULT data.
>
> Fixes: 53ad07e9823b ("wifi: cfg80211: support reporting failed links")
> Signed-off-by: Veerendranath Jakkam <quic_vjakkam@quicinc.com>
> ---
> v2:
> - Add "Fixes:" tag in commit text.
> ---
> net/wireless/sme.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/net/wireless/sme.c b/net/wireless/sme.c
> index e419aa8c4a5a..d9d7bf8bb5c1 100644
> --- a/net/wireless/sme.c
> +++ b/net/wireless/sme.c
> @@ -1045,6 +1045,7 @@ void cfg80211_connect_done(struct net_device *dev,
> cfg80211_hold_bss(
> bss_from_pub(params->links[link].bss));
> ev->cr.links[link].bss = params->links[link].bss;
> + ev->cr.links[link].status = params->links[link].status;
>
> if (params->links[link].addr) {
> ev->cr.links[link].addr = next;
> --
> 2.34.1
>
LGTM,
Reviewed-by: Carlos Llamas <cmllamas@google.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-07-24 13:40 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-07-24 12:53 [PATCH v2] wifi: cfg80211: fix reporting failed MLO links status with cfg80211_connect_done Veerendranath Jakkam
2024-07-24 13:40 ` Carlos Llamas
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).