From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [185.203.201.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DC8E21C7660 for ; Tue, 3 Sep 2024 09:01:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.203.201.7 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725354096; cv=none; b=d6m/pVIANigS4wQ/L5y5lwNYkKNh/X8pqdo200dzaiEq8P/n3/vgazs7EiieIw72CGD9seUqmSJH9aSV9y/MLY/hy7o3TJHAuxwU6V/bF1VCpF+SDWmckHn26RnSth2Il1g9wDVmsTk3eWDi2e9Q5M/ZWVgz2NSfmIr+6+EkCBI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725354096; c=relaxed/simple; bh=BoO78xQ/ayPNhV4nvO58szEXQHCiaY0ES7P2J0hXhzg=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=VDl/rJMkQTIAuvhSl6Hud+PJLvUXO4tf1C/6u5Tc8D7+ZVX/Re6z8kuBG6xRr8qqx/BMYPtgqLoFgJKpRWCSqp77NwEJGJBl0rwfAf1Ws9Ydd+3meEFMqDBdhMQqAGiL8bWhjKu817ysRrzV57fsUHlxqjX8tPKeb8f7wbDMUlA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de; spf=pass smtp.mailfrom=pengutronix.de; arc=none smtp.client-ip=185.203.201.7 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pengutronix.de Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1slPPi-0008MR-C4; Tue, 03 Sep 2024 11:01:26 +0200 Received: from [2a0a:edc0:2:b01:1d::c5] (helo=pty.whiteo.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1slPPh-0058uJ-L2; Tue, 03 Sep 2024 11:01:25 +0200 Received: from sha by pty.whiteo.stw.pengutronix.de with local (Exim 4.96) (envelope-from ) id 1slPPh-004OJX-1j; Tue, 03 Sep 2024 11:01:25 +0200 Date: Tue, 3 Sep 2024 11:01:25 +0200 From: Sascha Hauer To: David Lin Cc: Francesco Dolcini , Calvin Owens , Brian Norris , Kalle Valo , "linux-wireless@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "kernel@pengutronix.de" Subject: Re: [EXT] [RFC PATCH 0/4] mwifiex: add support for iw61x Message-ID: References: Precedence: bulk X-Mailing-List: linux-wireless@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-Accept-Language: de,en X-Accept-Content-Type: text/plain X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: sha@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-wireless@vger.kernel.org On Tue, Sep 03, 2024 at 07:57:51AM +0000, David Lin wrote: > > From: Sascha Hauer > > Sent: Tuesday, September 3, 2024 3:52 PM > > To: David Lin > > Cc: Francesco Dolcini ; Calvin Owens > > ; Brian Norris ; Kalle Valo > > ; linux-wireless@vger.kernel.org; > > linux-kernel@vger.kernel.org; kernel@pengutronix.de > > Subject: Re: [EXT] [RFC PATCH 0/4] mwifiex: add support for iw61x > > > > Caution: This is an external email. Please take care when clicking links or > > opening attachments. When in doubt, report the message using the 'Report > > this email' button > > > > > > On Tue, Sep 03, 2024 at 07:35:59AM +0000, David Lin wrote: > > > > From: Sascha Hauer > > > > Sent: Tuesday, September 3, 2024 3:30 PM > > > > To: David Lin > > > > Cc: Francesco Dolcini ; Calvin Owens > > > > ; Brian Norris ; Kalle > > > > Valo ; linux-wireless@vger.kernel.org; > > > > linux-kernel@vger.kernel.org; kernel@pengutronix.de > > > > Subject: Re: [EXT] [RFC PATCH 0/4] mwifiex: add support for iw61x > > > > > > > > Caution: This is an external email. Please take care when clicking > > > > links or opening attachments. When in doubt, report the message > > > > using the 'Report this email' button > > > > > > > > > > > > On Tue, Sep 03, 2024 at 06:39:15AM +0000, David Lin wrote: > > > > > > > > > Not only this code segment. In fact, you did not add VDLL > > > > > > > > > data patch support > > > > > > > > to sdio.c. > > > > > > > > > If you try to add the code and do test, you will know what > > > > > > > > > is missing in your > > > > > > > > code. > > > > > > > > > > > > > > > > Could you point me to the code you mean? > > > > > > > > > > > > > > > > Sascha > > > > > > > > > > > > > > > > > > > > > > I only know the porting VDLL code in nxpwifi. > > > > > > > > > > > > Yes, and I asked for a pointer to that code, some function name, > > > > > > or file/line or whatever, because I looked at the nxpwifi driver > > > > > > and don't know what you mean with "VDLL data patch support" in > > sdio.c. > > > > > > > > > > > > Sascha > > > > > > > > > > > > > > > > It is better for you to check MXM driver. It is the same as > > > > > Mwifiex which > > > > support all SDIO modes. > > > > > > > > Now I am confused. You said: > > > > > > > > > In fact, you did not add VDLL data patch support to sdio.c > > > > > > > > I was under the assumption that the nxpwifi driver that you > > > > specifically posted for the iw61x chipset should contain this code. Isn't that > > the case? > > > > > > > > BTW did you really mean "VDLL data patch" or did you mean "VDLL data > > > > path"? > > > > > > > > > > Sorry VDLL data path. > > > You did not add the code to support this new SDIO data type in your patch. > > > > > > Please check MXM driver which supports all SDIO modes. > > > > But why? The nxpwifi driver is much closer to the mwifiex driver and much > > better readable, so I would rather pick the missing pieces from there. > > > > Sascha > > > > Nxpwifi only supports SDIO new mode. MXM and Mwifiex supports normal and new SDIO modes. By SDIO new mode I assume that you mean the supports_sdio_new_mode variable in the mwifiex driver. This is used when a chip supports it The iw61x supports this new mode and the iw61x also is the only chip which needs the VDLL code. So would I have to add something to the "normal" SDIO mode? Sascha -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |