From: "Dr. David Alan Gilbert" <linux@treblig.org>
To: Kalle Valo <kvalo@kernel.org>
Cc: pkshih@realtek.com, linux-wireless@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] rtlwifi: Remove more unused functions
Date: Mon, 4 Nov 2024 12:52:47 +0000 [thread overview]
Message-ID: <ZyjDn0R7gzDQ4jnT@gallifrey> (raw)
In-Reply-To: <87y11zxwlr.fsf@kernel.org>
* Kalle Valo (kvalo@kernel.org) wrote:
> linux@treblig.org writes:
>
> > From: "Dr. David Alan Gilbert" <linux@treblig.org>
> >
> > exhalbtc_dbg_control(), exhalbtc_stack_update_profile_info(),
> > exhalbtc_set_hci_version(), and exhalbtc_set_bt_patch_version() are
> > unused since their addition in 2014 by
> > commit aa45a673b291 ("rtlwifi: btcoexist: Add new mini driver")
> >
> > Remove them.
> >
> > Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
>
> 'wifi:' missing.
Oops, can add that.
> Also in both patches the subject could be more unique.
Do you have suggestions? I don't know the code to give good titles.
They're both 'btcoexist'; I could merge them into one
wifi: wtlwifi: Remove btcoexist deadcode
Dave
>
> --
> https://patchwork.kernel.org/project/linux-wireless/list/
>
> https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
--
-----Open up your eyes, open up your mind, open up your code -------
/ Dr. David Alan Gilbert | Running GNU/Linux | Happy \
\ dave @ treblig.org | | In Hex /
\ _________________________|_____ http://www.treblig.org |_______/
next prev parent reply other threads:[~2024-11-04 12:52 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-03 15:38 [PATCH 0/2] Realtek wifi deadcoding linux
2024-11-03 15:38 ` [PATCH 1/2] rtlwifi: Remove unused functions linux
2024-11-04 7:53 ` Kalle Valo
2024-11-03 15:38 ` [PATCH 2/2] rtlwifi: Remove more " linux
2024-11-04 7:54 ` Kalle Valo
2024-11-04 12:52 ` Dr. David Alan Gilbert [this message]
2024-11-04 14:16 ` Kalle Valo
2024-11-04 14:44 ` Dr. David Alan Gilbert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZyjDn0R7gzDQ4jnT@gallifrey \
--to=linux@treblig.org \
--cc=kvalo@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=pkshih@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox