From: Pablo MARTIN-GOMEZ <pmartin-gomez@freebox.fr>
To: Reshma Immaculate Rajkumar <reshma.rajkumar@oss.qualcomm.com>,
ath12k@lists.infradead.org
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH ath-next] wifi: ath12k: Pass the correct value of each TID during a stop AMPDU session
Date: Wed, 25 Feb 2026 13:57:15 +0100 [thread overview]
Message-ID: <a1057b77-de96-4fa2-8eb7-54320f0f3aca@freebox.fr> (raw)
In-Reply-To: <20260225114912.966266-1-reshma.rajkumar@oss.qualcomm.com>
Hello,
On 25/02/2026 12:49, Reshma Immaculate Rajkumar wrote:
> With traffic ongoing for data TID [TID 0], an ADDBA request to
It's a DELBA that is going to be sent to stop a BA session.
> stop AMPDU for the BA session was received on management TID [TID 4].
> The corresponding TID number was incorrectly passed to stop the BA session,
> resulting in the BA session for data TIDs being stopped and the BA size
> being reduced to 1, causing an overall dip in TCP throughput.
I'm guessing you only tested TCP traffic, but UDP throughput is also going to dip.
>
> Fix this issue by passing the correct argument from
> ath12k_dp_rx_ampdu_stop() to ath12k_dp_arch_peer_rx_tid_reo_update()
> during an AMPDU stop session. Instead of passing peer->dp_peer->rx_tid,
> which is the base address of the array, corresponding to TID 0, pass
> the value of &peer->dp_peer->rx_tid[params->tid]. With this, the
> different TID numbers are accounted for.
>
> Tested-on: QCN9274 hw2.0 PCI WLAN.WBE.1.5-01651-QCAHKSWPL_SILICONZ-1
>
> Fixes: d889913205cf ("wifi: ath12k: driver for Qualcomm Wi-Fi 7 devices")
> Signed-off-by: Reshma Immaculate Rajkumar <reshma.rajkumar@oss.qualcomm.com>
[...]
Pablo MG
prev parent reply other threads:[~2026-02-25 12:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-25 11:49 [PATCH ath-next] wifi: ath12k: Pass the correct value of each TID during a stop AMPDU session Reshma Immaculate Rajkumar
2026-02-25 12:57 ` Pablo MARTIN-GOMEZ [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a1057b77-de96-4fa2-8eb7-54320f0f3aca@freebox.fr \
--to=pmartin-gomez@freebox.fr \
--cc=ath12k@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=reshma.rajkumar@oss.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox