From: Jeff Johnson <jeff.johnson@oss.qualcomm.com>
To: Nicolas Escande <nico.escande@gmail.com>, ath12k@lists.infradead.org
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH ath-next v5] wifi: ath12k: avoid dynamic alloc when parsing wmi tb
Date: Mon, 30 Mar 2026 12:38:21 -0700 [thread overview]
Message-ID: <a124d5d0-ef46-448b-b226-8642da61e0cd@oss.qualcomm.com> (raw)
In-Reply-To: <20260330102434.13136-1-nico.escande@gmail.com>
On 3/30/2026 3:24 AM, Nicolas Escande wrote:
> diff --git a/drivers/net/wireless/ath/ath12k/core.c b/drivers/net/wireless/ath/ath12k/core.c
> index c31c47fb5a73..76060d448920 100644
> --- a/drivers/net/wireless/ath/ath12k/core.c
> +++ b/drivers/net/wireless/ath/ath12k/core.c
> @@ -2258,6 +2258,7 @@ void ath12k_core_free(struct ath12k_base *ab)
> timer_delete_sync(&ab->rx_replenish_retry);
> destroy_workqueue(ab->workqueue_aux);
> destroy_workqueue(ab->workqueue);
> + ath12k_wmi_free();
nit:
the order of init is ab, wq, wq_aux, wmi
the order of free should be reversed: wmi, wq_aux, wq, ab
which matches the init error path
> kfree(ab);
> }
>
other than that, this looks good to me
next prev parent reply other threads:[~2026-03-30 19:38 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-30 10:24 [PATCH ath-next v5] wifi: ath12k: avoid dynamic alloc when parsing wmi tb Nicolas Escande
2026-03-30 19:38 ` Jeff Johnson [this message]
2026-04-02 10:44 ` Nicolas Escande
2026-03-31 2:44 ` Baochen Qiang
2026-04-02 10:47 ` Nicolas Escande
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a124d5d0-ef46-448b-b226-8642da61e0cd@oss.qualcomm.com \
--to=jeff.johnson@oss.qualcomm.com \
--cc=ath12k@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=nico.escande@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox