From: Arend Van Spriel <arend.vanspriel@broadcom.com>
To: Alexei Avshalom Lazar <ailizaro@codeaurora.org>,
Johannes Berg <johannes@sipsolutions.net>
Cc: linux-wireless@vger.kernel.org, wil6210@qti.qualcomm.com
Subject: Re: [PATCH v7 2/2] nl support for dmtool
Date: Mon, 19 Aug 2019 10:20:49 +0200 [thread overview]
Message-ID: <a1edb82d-6bdb-a44d-4781-c05358fffad9@broadcom.com> (raw)
In-Reply-To: <1566137719-3544-3-git-send-email-ailizaro@codeaurora.org>
On 8/18/2019 4:15 PM, Alexei Avshalom Lazar wrote:
> Signed-off-by: Alexei Avshalom Lazar <ailizaro@codeaurora.org>
> ---
> drivers/net/wireless/ath/wil6210/Kconfig | 11 ++
> drivers/net/wireless/ath/wil6210/Makefile | 1 +
> drivers/net/wireless/ath/wil6210/ioctl.c | 245 +++++++++++++++++++++++++++++
> drivers/net/wireless/ath/wil6210/netdev.c | 8 +
> drivers/net/wireless/ath/wil6210/wil6210.h | 1 +
> include/uapi/linux/wil6210_uapi.h | 77 +++++++++
> 6 files changed, 343 insertions(+)
> create mode 100644 drivers/net/wireless/ath/wil6210/ioctl.c
> create mode 100644 include/uapi/linux/wil6210_uapi.h
>
> diff --git a/drivers/net/wireless/ath/wil6210/Kconfig b/drivers/net/wireless/ath/wil6210/Kconfig
> index 0d1a8da..48b14de 100644
> --- a/drivers/net/wireless/ath/wil6210/Kconfig
> +++ b/drivers/net/wireless/ath/wil6210/Kconfig
> @@ -53,3 +53,14 @@ config WIL6210_DEBUGFS
> option if you are interested in debugging the driver.
>
> If unsure, say Y to make it easier to debug problems.
> +
> +config WIL6210_WRITE_IOCTL
> + bool "wil6210 write ioctl to the device"
> + depends on WIL6210
> + default y
> + help
> + Say Y here to allow write-access from user-space to
> + the device memory through ioctl. This is useful for
> + debugging purposes only.
> +
> + If unsure, say N.
I was about to scream in horror seeing this patch, but noticed you
rectified it in v8. *Phew*
Regards,
Arend
prev parent reply other threads:[~2019-08-19 8:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-18 14:15 [PATCH v7 0/2] Add support for new channels on 60GHz band Alexei Avshalom Lazar
2019-08-18 14:15 ` [PATCH v7 1/2] wil6210: Add EDMG channel support Alexei Avshalom Lazar
2019-08-18 14:15 ` [PATCH v7 2/2] nl support for dmtool Alexei Avshalom Lazar
2019-08-19 8:20 ` Arend Van Spriel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a1edb82d-6bdb-a44d-4781-c05358fffad9@broadcom.com \
--to=arend.vanspriel@broadcom.com \
--cc=ailizaro@codeaurora.org \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=wil6210@qti.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox