RE: [PATCH rtw-next v2] wifi: rtl8xxxu: expose efuse via debugfs

[Ping-Ke Shih <pkshih@realtek.com>]

Martin Kaistra <martin.kaistra@linutronix.de> wrote:
> The efuse contains the mac address and calibration data. During
> manufacturing and testing it can be necessary to read and check this
> data.
> 
> Add a debugfs interface to make it available to userspace.
> 
> Signed-off-by: Martin Kaistra <martin.kaistra@linutronix.de>
> ---
> Changes in v2:
> - remove unnecessary comment
> - use debugfs_short_fops
> 
>  drivers/net/wireless/realtek/rtl8xxxu/core.c | 22 ++++++++++++++++++++
>  1 file changed, 22 insertions(+)
> 
> diff --git a/drivers/net/wireless/realtek/rtl8xxxu/core.c
> b/drivers/net/wireless/realtek/rtl8xxxu/core.c
> index 831b5025c6349..aea706f0251d8 100644
> --- a/drivers/net/wireless/realtek/rtl8xxxu/core.c
> +++ b/drivers/net/wireless/realtek/rtl8xxxu/core.c
> @@ -1901,6 +1901,27 @@ static void rtl8xxxu_dump_efuse(struct rtl8xxxu_priv *priv)
>                        priv->efuse_wifi.raw, EFUSE_MAP_LEN, true);
>  }
> 
> +static ssize_t read_file_efuse(struct file *file, char __user *user_buf,
> +                              size_t count, loff_t *ppos)
> +{
> +       struct rtl8xxxu_priv *priv = file_inode(file)->i_private;
> +
> +       return simple_read_from_buffer(user_buf, count, ppos,
> +                                      priv->efuse_wifi.raw, EFUSE_MAP_LEN);
> +}
> +
> +static const struct debugfs_short_fops fops_efuse = {
> +       .read = read_file_efuse,
> +};
> +
> +static void rtl8xxxu_debugfs_init(struct rtl8xxxu_priv *priv)
> +{
> +       struct dentry *phydir;
> +
> +       phydir = debugfs_create_dir("rtl8xxxu", priv->hw->wiphy->debugfsdir);
> +       debugfs_create_file("efuse", 0400, phydir, priv, &fops_efuse);
> +}
> +

Could you please try if this would encounter build error without
CFG80211_DEBUGFS?

Otherwise, looks good to me.

>  void rtl8xxxu_reset_8051(struct rtl8xxxu_priv *priv)
>  {
>         u8 val8;
> @@ -7974,6 +7995,7 @@ static int rtl8xxxu_probe(struct usb_interface *interface,
>         }
> 
>         rtl8xxxu_init_led(priv);
> +       rtl8xxxu_debugfs_init(priv);
> 
>         return 0;
> 
> --
> 2.39.5