From: Ping-Ke Shih <pkshih@realtek.com>
To: Bitterblue Smith <rtl8821cerfe2@gmail.com>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Cc: Larry Finger <Larry.Finger@lwfinger.net>
Subject: RE: [PATCH] wifi: rtlwifi: rtl8192de: Fix byte order of chip version
Date: Mon, 15 Jan 2024 01:55:09 +0000 [thread overview]
Message-ID: <a30c3c771436456e8364504cec082fff@realtek.com> (raw)
In-Reply-To: <81b6c452-e940-423a-acf7-4a7b7c5e7847@gmail.com>
> -----Original Message-----
> From: Bitterblue Smith <rtl8821cerfe2@gmail.com>
> Sent: Saturday, January 13, 2024 6:50 AM
> To: linux-wireless@vger.kernel.org
> Cc: Ping-Ke Shih <pkshih@realtek.com>; Larry Finger <Larry.Finger@lwfinger.net>
> Subject: [PATCH] wifi: rtlwifi: rtl8192de: Fix byte order of chip version
>
> The chip version stored in the efuse is currently assumed to be in
> big endian order:
>
> #define EEPROME_CHIP_VERSION_L 0x3FF
> #define EEPROME_CHIP_VERSION_H 0x3FE
>
> But other 2-byte things in the efuse are stored in little endian order.
> For example, the EEPROM ID, the vendor ID, the product ID.
>
> The out-of-kernel driver for the USB version of the chip uses the same
> macros and version detection code as this driver. They recognise
> 0xaa55, 0x9966, and 0xcc33 as correct versions. With the original
> macros, my device's version is the unrecognised value of 0x33cc. This
> seems like a mistake.
I will check this internally. Please wait a while.
next prev parent reply other threads:[~2024-01-15 1:55 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-12 22:50 [PATCH] wifi: rtlwifi: rtl8192de: Fix byte order of chip version Bitterblue Smith
2024-01-15 1:55 ` Ping-Ke Shih [this message]
2024-01-15 5:42 ` Ping-Ke Shih
2024-01-15 12:50 ` Bitterblue Smith
2024-01-16 0:56 ` Ping-Ke Shih
2024-01-16 15:37 ` Bitterblue Smith
2024-01-17 0:15 ` Ping-Ke Shih
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a30c3c771436456e8364504cec082fff@realtek.com \
--to=pkshih@realtek.com \
--cc=Larry.Finger@lwfinger.net \
--cc=linux-wireless@vger.kernel.org \
--cc=rtl8821cerfe2@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).