From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ADDC2C2D0C2 for ; Tue, 31 Dec 2019 09:36:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 76A25206DB for ; Tue, 31 Dec 2019 09:36:17 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="key not found in DNS" (0-bit key) header.d=mg.codeaurora.org header.i=@mg.codeaurora.org header.b="K6tgzazv" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725906AbfLaJgQ (ORCPT ); Tue, 31 Dec 2019 04:36:16 -0500 Received: from mail25.static.mailgun.info ([104.130.122.25]:16592 "EHLO mail25.static.mailgun.info" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725770AbfLaJgQ (ORCPT ); Tue, 31 Dec 2019 04:36:16 -0500 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1577784975; h=Message-ID: References: In-Reply-To: Subject: Cc: To: From: Date: Content-Transfer-Encoding: Content-Type: MIME-Version: Sender; bh=PgBVetFV5i/BVN9CTKkEURi7vaEtzmcR53n7QM3V48k=; b=K6tgzazvFDTKp1MS2SAjYd4B1LxGVzA7hstXBjVWrYxXzc6gFDFZCj3/bvZckFVel8CFoDP0 VlxK0yFd1RWGdjiwscrjlbaQx6gc+ZTziGS44g6Q/ZffHR+B+OF0t5Ct6+x3yTjYpM41EjqR dDqs9cSGv+2yMr4skmkUjAqpB8U= X-Mailgun-Sending-Ip: 104.130.122.25 X-Mailgun-Sid: WyI3YTAwOSIsICJsaW51eC13aXJlbGVzc0B2Z2VyLmtlcm5lbC5vcmciLCAiYmU5ZTRhIl0= Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by mxa.mailgun.org with ESMTP id 5e0b168b.7f81591e4e30-smtp-out-n01; Tue, 31 Dec 2019 09:36:11 -0000 (UTC) Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 4236AC4479C; Tue, 31 Dec 2019 09:36:11 +0000 (UTC) Received: from mail.codeaurora.org (localhost.localdomain [127.0.0.1]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: wgong) by smtp.codeaurora.org (Postfix) with ESMTPSA id EDD0DC43383; Tue, 31 Dec 2019 09:36:10 +0000 (UTC) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Tue, 31 Dec 2019 17:36:10 +0800 From: wgong@codeaurora.org To: Justin Capella Cc: ath10k , linux-wireless@vger.kernel.org Subject: Re: [PATCH] ath10k: select the min len of RX skb for sdio In-Reply-To: References: <20191220063829.11873-1-wgong@codeaurora.org> Message-ID: X-Sender: wgong@codeaurora.org User-Agent: Roundcube Webmail/1.3.9 Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On 2019-12-20 20:11, Justin Capella wrote: > If the data is invalid I think it should be discarded and a warning > displayed, it is just as bad to pass too little data isn't it? Then > you potentially have uninitialized data? Or pointers to nonsense? > There is a good chance I am misunderstanding though, I just wanted to > make sure you had considered those cases and the word alignment if > that applies to this type of bus? yes, patch v2: https://patchwork.kernel.org/patch/11313849/