From: Ping-Ke Shih <pkshih@realtek.com>
To: Bitterblue Smith <rtl8821cerfe2@gmail.com>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Cc: Sascha Hauer <sha@pengutronix.de>
Subject: RE: [PATCH v2 2/3] wifi: rtw88: Handle C2H_ADAPTIVITY in rtw_fw_c2h_cmd_handle()
Date: Thu, 19 Dec 2024 06:19:22 +0000 [thread overview]
Message-ID: <a5d37be29d444e7caa87b39416638725@realtek.com> (raw)
In-Reply-To: <96e52b03-be8d-4050-ae71-bfdb478ff42f@gmail.com>
Bitterblue Smith <rtl8821cerfe2@gmail.com> wrote:
> The firmware message C2H_ADAPTIVITY is currently handled in
> rtw_fw_c2h_cmd_rx_irqsafe(), which runs in the RX workqueue, but it's
> not "irqsafe" with USB because it sleeps (reads hardware registers).
> This becomes a problem after the next patch, which will create the RX
> workqueue with the flag WQ_BH.
>
> To avoid sleeping when it's not allowed, handle C2H_ADAPTIVITY in
> rtw_fw_c2h_cmd_handle(), which runs in the c2h workqueue.
>
> Signed-off-by: Bitterblue Smith <rtl8821cerfe2@gmail.com>
Acked-by: Ping-Ke Shih <pkshih@realtek.com>
next prev parent reply other threads:[~2024-12-19 6:19 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-18 22:33 [PATCH v2 1/3] wifi: rtw88: usb: Copy instead of cloning the RX skb Bitterblue Smith
2024-12-18 22:34 ` [PATCH v2 2/3] wifi: rtw88: Handle C2H_ADAPTIVITY in rtw_fw_c2h_cmd_handle() Bitterblue Smith
2024-12-19 6:19 ` Ping-Ke Shih [this message]
2024-12-18 22:35 ` [PATCH v2 3/3] wifi: rtw88: usb: Preallocate and reuse the RX skbs Bitterblue Smith
2024-12-19 7:18 ` Ping-Ke Shih
2024-12-19 6:17 ` [PATCH v2 1/3] wifi: rtw88: usb: Copy instead of cloning the RX skb Ping-Ke Shih
2024-12-19 11:15 ` Bitterblue Smith
2024-12-20 0:13 ` Ping-Ke Shih
2024-12-23 8:07 ` Ping-Ke Shih
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a5d37be29d444e7caa87b39416638725@realtek.com \
--to=pkshih@realtek.com \
--cc=linux-wireless@vger.kernel.org \
--cc=rtl8821cerfe2@gmail.com \
--cc=sha@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).