From: Ping-Ke Shih <pkshih@realtek.com>
To: Kalle Valo <kvalo@kernel.org>
Cc: "Larry.Finger@lwfinger.net" <Larry.Finger@lwfinger.net>,
"stable@vger.kernel.org" <stable@vger.kernel.org>,
Bernie Huang <phhuang@realtek.com>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: RE: [PATCH v6.0-rc] wifi: rtw89: free unused skb to prevent memory leak
Date: Mon, 26 Sep 2022 05:45:42 +0000 [thread overview]
Message-ID: <a72c494ad56c44d0a2a4219d0a671ab5@realtek.com> (raw)
In-Reply-To: <87illa7lkb.fsf@kernel.org>
> -----Original Message-----
> From: Kalle Valo <kvalo@kernel.org>
> Sent: Monday, September 26, 2022 1:27 PM
> To: Ping-Ke Shih <pkshih@realtek.com>
> Cc: Larry.Finger@lwfinger.net; stable@vger.kernel.org; Bernie Huang <phhuang@realtek.com>;
> linux-wireless@vger.kernel.org
> Subject: Re: [PATCH v6.0-rc] wifi: rtw89: free unused skb to prevent memory leak
>
> Ping-Ke Shih <pkshih@realtek.com> writes:
>
> > From: Po-Hao Huang <phhuang@realtek.com>
> >
> > This avoid potential memory leak under power saving mode.
> >
> > Fixes: fc5f311fce74 ("rtw89: don't flush hci queues and send h2c if power is off")
> > Cc: stable@vger.kernel.org
> > Cc: Larry Finger <Larry.Finger@lwfinger.net>
> > Signed-off-by: Po-Hao Huang <phhuang@realtek.com>
> > Signed-off-by: Ping-Ke Shih <pkshih@realtek.com>
> > Signed-off-by: Kalle Valo <kvalo@kernel.org>
> > Link: https://lore.kernel.org/r/20220916033811.13862-6-pkshih@realtek.com
> > ---
> > Hi Kalle,
> >
> > We want this patch go to v6.0-rc, because it can fix memleak caused by another
> > patch. For users, this driver eats memory and could lead out-of-memory
> > finally.
> >
> > This patch has been merged into wireless-next, but I forget to add "Fixes"
> > tag and Cc stable, so I add them to commit messages. If this works, I will
> > prepare another patch for v5.19.
>
> -rc7 is already released, so we are quite late in the cycle, and I'm not
> planning to submit another pull request for v6.0 unless something really
> major happens. So I think it's better that you wait for the -next commit
> to reach Linus' tree (should happen in next two weeks or so) and then
> submit a patch to stable releases.
>
Got it. I will do it weeks later. Thanks.
Ping-Ke
prev parent reply other threads:[~2022-09-26 5:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-26 2:15 [PATCH v6.0-rc] wifi: rtw89: free unused skb to prevent memory leak Ping-Ke Shih
2022-09-26 5:26 ` Kalle Valo
2022-09-26 5:45 ` Ping-Ke Shih [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a72c494ad56c44d0a2a4219d0a671ab5@realtek.com \
--to=pkshih@realtek.com \
--cc=Larry.Finger@lwfinger.net \
--cc=kvalo@kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=phhuang@realtek.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox