linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Arend van Spriel <arend.vanspriel@broadcom.com>
To: Martin Michlmayr <tbm@cyrius.com>
Cc: Franky Lin <franky.lin@broadcom.com>,
	Hante Meuleman <hante.meuleman@broadcom.com>,
	linux-wireless@vger.kernel.org,
	brcm80211-dev-list.pdl@broadcom.com
Subject: Re: [PATCH] brcmfmac: iso cfg80211: Fix grammar issue in error message
Date: Sat, 10 Jun 2017 11:33:45 +0200	[thread overview]
Message-ID: <a79b0fa3-2f7d-e704-371d-c2eec383afaf@broadcom.com> (raw)
In-Reply-To: <20170610092247.2gz6sydytp5pomq6@jirafa.cyrius.com>

Hah. That is (unintended?) fun. I actually meant to change the subject
from "cfg80211: Fix grammar issue in error message" into "brcmfmac: Fix
grammar issue in error message". Using the abbreviation "iso" in this
context was maybe a bit misleading of me.

One more purely educational note: when sending a reworked patch it is
good practice to use "[PATCH V2]" in the subject and add a changelog
between the signature tags and the diff separated by "---" so people now
what changed, ie.:

---
 changes:
  V2:
   - updated subject prefix.
---

Thanks,
Arend

On 10-06-17 11:22, Martin Michlmayr wrote:
> Fix grammar issue in error message about ISO3166.
> 
> Signed-off-by: Martin Michlmayr <tbm@cyrius.com>
> Acked-by: Arend van Spriel <arend.vanspriel@broadcom.com>
> 
> diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c
> index cd1d6730eab7..c1ad81f34658 100644
> --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c
> +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c
> @@ -6767,7 +6767,7 @@ static void brcmf_cfg80211_reg_notifier(struct wiphy *wiphy,
>  	/* ignore non-ISO3166 country codes */
>  	for (i = 0; i < sizeof(req->alpha2); i++)
>  		if (req->alpha2[i] < 'A' || req->alpha2[i] > 'Z') {
> -			brcmf_err("not a ISO3166 code (0x%02x 0x%02x)\n",
> +			brcmf_err("not an ISO3166 code (0x%02x 0x%02x)\n",
>  				  req->alpha2[0], req->alpha2[1]);
>  			return;
>  		}
> 

  reply	other threads:[~2017-06-10  9:33 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-08  8:01 [PATCH] cfg80211: Fix grammar issue in error message Martin Michlmayr
2017-06-08  8:23 ` Arend van Spriel
2017-06-10  9:22   ` [PATCH] brcmfmac: iso " Martin Michlmayr
2017-06-10  9:33     ` Arend van Spriel [this message]
2017-06-10  9:40       ` [PATCH V3] brcmfmac: " Martin Michlmayr
2017-06-13  6:59         ` [V3] " Kalle Valo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a79b0fa3-2f7d-e704-371d-c2eec383afaf@broadcom.com \
    --to=arend.vanspriel@broadcom.com \
    --cc=brcm80211-dev-list.pdl@broadcom.com \
    --cc=franky.lin@broadcom.com \
    --cc=hante.meuleman@broadcom.com \
    --cc=linux-wireless@vger.kernel.org \
    --cc=tbm@cyrius.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).